Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(sveltekit): Add telemetry collection #455

Merged
merged 4 commits into from
Sep 14, 2023
Merged

feat(sveltekit): Add telemetry collection #455

merged 4 commits into from
Sep 14, 2023

Conversation

Lms24
Copy link
Member

@Lms24 Lms24 commented Sep 14, 2023 •
edited
Loading

This PR adds telemetry collection to the SvelteKit wizard. Concretely:

  • Transaction and steps via withTelemetry and traceStep:
    image
  • capture minimal exceptions around known failure points
  • set tags around
    • Svelte and Kit versions
    • Decisions to continue if precondition checks fail
    • Whether files were merged (AST mods) or newly created
    • Whether file modifications were successful

closes #451

@Lms24 Lms24 requested review from lforst and smeubank September 14, 2023 08:08
@github-actions
Copy link

github-actions bot commented Sep 14, 2023 •
edited
Loading

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against 044a2de

@Lms24 Lms24 mentioned this pull request Sep 14, 2023
Merged
@Lms24 Lms24 force-pushed the lms/feat-telemetry-sveltekit branch from 05b2855 to 34cf974 Compare September 14, 2023 08:13
lforst
lforst reviewed Sep 14, 2023
View reviewed changes
src/sveltekit/sdk-setup.ts Outdated Show resolved Hide resolved
lforst
lforst previously approved these changes Sep 14, 2023
View reviewed changes
@lforst lforst dismissed their stale review September 14, 2023 12:46

accident

@Lms24 Lms24 force-pushed the lms/feat-telemetry-sveltekit branch from 1748844 to 044a2de Compare September 14, 2023 12:56
@Lms24 Lms24 merged commit f95b073 into master Sep 14, 2023
9 checks passed
@Lms24 Lms24 deleted the lms/feat-telemetry-sveltekit branch September 14, 2023 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lforst lforst lforst approved these changes

@smeubank smeubank Awaiting requested review from smeubank

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add telemetry to SvelteKit wizard
2 participants
@Lms24 @lforst