Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Source Maps Debug ID in Hermes bundle #2947

Closed
5 tasks done
Tracked by #3102 ...
krystofwoldrich opened this issue Mar 31, 2023 · 4 comments
Closed
5 tasks done
Tracked by #3102 ...

Add support for Source Maps Debug ID in Hermes bundle #2947

krystofwoldrich opened this issue Mar 31, 2023 · 4 comments

Comments

@krystofwoldrich
Copy link
Member

krystofwoldrich commented Mar 31, 2023

Description

Based on the initial testing, the current way of injecting Debug ID into a bundle file works only for plain text JS files.

Tasks

  1. Status: Backlog
  2. Platform: React-Native Status: Backlog repository maintenance

Debug ID must be propagated to Hermes Combined Source Map, but CLI at the moment doesn't automatically upload combined source maps.

Related tasks

  1. Platform: React-Native Status: Backlog component: react-native
@marandaneto
Copy link
Contributor

@krystofwoldrich you can link it to getsentry/team-mobile#133

@krystofwoldrich krystofwoldrich changed the title Add support for Source Maps DebugID in Hermes bundle Add support for Source Maps Debug ID in Hermes bundle Jun 20, 2023
@krystofwoldrich
Copy link
Member Author

We might be able to use getPolyfills to add the debug id holder object to the JS runtime

https://facebook.github.io/metro/docs/configuration#getpolyfills

@shanamatthews
Copy link

Hey @krystofwoldrich - I know we have docs on uploading source maps with Hermes, are there any updates needed based on these improvements?

@krystofwoldrich
Copy link
Member Author

krystofwoldrich commented Oct 24, 2023

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

6 participants