Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix OpenAI tests in POTel #3738

Draft
wants to merge 4 commits into
base: potel-base
Choose a base branch
from
Draft

Conversation

antonpirker
Copy link
Member

No description provided.

@antonpirker antonpirker changed the base branch from master to potel-base November 5, 2024 14:27
@@ -330,6 +330,7 @@ async def test_streaming_chat_completion_async(
pass # if tiktoken is not installed, we can't guarantee token usage will be calculated properly


@pytest.mark.forked
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to fork tests that capture exceptions. (Somehow capturing exceptions messes up the next sentry_sdk.init() and capturing events/exeptions in following tests)

Copy link

codecov bot commented Nov 5, 2024

❌ 285 Tests Failed:

Tests completed Failed Passed Skipped
15934 285 15649 3886
View the top 3 failed tests by shortest run time
tests.integrations.arq.test_arq test_job_retry[init_arq]
Stack Traces | 0.063s run time
.../integrations/arq/test_arq.py:180: in test_job_retry
    assert event["contexts"]["trace"]["status"] == "aborted"
E   AssertionError: assert 'ok' == 'aborted'
E     - aborted
E     + ok
tests.integrations.arq.test_arq test_job_retry[init_arq_with_dict_settings]
Stack Traces | 0.063s run time
.../integrations/arq/test_arq.py:180: in test_job_retry
    assert event["contexts"]["trace"]["status"] == "aborted"
E   AssertionError: assert 'ok' == 'aborted'
E     - aborted
E     + ok
tests.integrations.celery.test_celery test_baggage_propagation
Stack Traces | 0.063s run time
.../integrations/celery/test_celery.py:519: in test_baggage_propagation
    assert sorted(result["baggage"].split(",")) == sorted(
E   AssertionError: assert ['custom=value', 'sentry-environment=production', 'sentry-release=abcdef', 'sentry-sample_rate=1.0', 'sentry-sampled=true', 'sentry-trace_id=1cad234ddbb4411318755fe6bc6327d8', 'sentry-transaction=%3Cunlabeled%20span%3E'] == ['custom=value', 'sentry-environment=production', 'sentry-release=abcdef', 'sentry-sample_rate=1.0', 'sentry-sampled=true', 'sentry-trace_id=1cad234ddbb4411318755fe6bc6327d8']
E     
E     Left contains one more item: 'sentry-transaction=%3Cunlabeled%20span%3E'
E     
E     Full diff:
E       [
E           'custom=value',
E           'sentry-environment=production',
E           'sentry-release=abcdef',
E           'sentry-sample_rate=1.0',
E           'sentry-sampled=true',
E           'sentry-trace_id=1cad234ddbb4411318755fe6bc6327d8',
E     +     'sentry-transaction=%3Cunlabeled%20span%3E',
E       ]

To view more test analytics, go to the Test Analytics Dashboard
📢 Thoughts on this report? Let us know!

@antonpirker antonpirker marked this pull request as draft December 4, 2024 14:42
@antonpirker antonpirker changed the title Fix OpenAI tests Fix OpenAI tests in POTel Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants