Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add httpcore based HTTP2Transport #3588

Merged
merged 30 commits into from
Oct 4, 2024
Merged
Show file tree
Hide file tree
Changes from 24 commits
Commits
Show all changes
30 commits
Select commit Hold shift + click to select a range
cac0a0e
feat: Add httpcore based HTTP2Transport
BYK Sep 18, 2024
3e3ac95
fix logic errors
BYK Sep 30, 2024
30c8039
fix f-string error pre py3.10
BYK Sep 30, 2024
0a4f4e5
fix f-string error pre py3.10
BYK Sep 30, 2024
488dbd0
fix type error
BYK Sep 30, 2024
8dfb4ec
remove type def referencing httpcore for now
BYK Sep 30, 2024
82ac048
disable new transport in 3.7-, add httpcore to test reqs
BYK Sep 30, 2024
8fa0a6a
use latest flake8
BYK Sep 30, 2024
fdf4943
add missing import
BYK Sep 30, 2024
bc470b3
go back to old flake8
BYK Sep 30, 2024
4168a17
don't use f-doc-strings
BYK Sep 30, 2024
727d6f1
one more lint fix
BYK Sep 30, 2024
929298a
fix test
BYK Sep 30, 2024
007bbbd
fix some typing issues
BYK Sep 30, 2024
5df98cc
unify duplicated code
BYK Oct 1, 2024
3af7a0a
Merge branch 'master' into byk/feat/http2
BYK Oct 1, 2024
9e7e6e9
fix some type issues
BYK Oct 1, 2024
a2f5cb8
Merge branch 'master' into byk/feat/http2
BYK Oct 1, 2024
0554647
moar typing fixes
BYK Oct 1, 2024
5bd5c42
MOAR TYPE FIXES!
BYK Oct 1, 2024
58b94c7
Merge branch 'master' into byk/feat/http2
BYK Oct 1, 2024
80f601f
loving python typing
BYK Oct 1, 2024
5243cbf
python typing fun continues
BYK Oct 1, 2024
0abc269
silence mypy
BYK Oct 1, 2024
19901fc
Merge branch 'master' into byk/feat/http2
BYK Oct 1, 2024
b8785d4
remove werid self-assignment line
BYK Oct 3, 2024
7795d8b
add transport_http2 to experiment constants list
BYK Oct 3, 2024
129ab07
safer fallback
BYK Oct 3, 2024
efd4e1c
Merge branch 'master' into byk/feat/http2
BYK Oct 3, 2024
b292dc5
Merge branch 'master' into byk/feat/http2
sentrivana Oct 4, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions requirements-testing.txt
Original file line number Diff line number Diff line change
Expand Up @@ -10,4 +10,6 @@ executing
asttokens
responses
pysocks
socksio
httpcore[http2]
setuptools
4 changes: 2 additions & 2 deletions sentry_sdk/client.py
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
)
from sentry_sdk.serializer import serialize
from sentry_sdk.tracing import trace
from sentry_sdk.transport import HttpTransport, make_transport
from sentry_sdk.transport import BaseHttpTransport, make_transport
from sentry_sdk.consts import (
DEFAULT_MAX_VALUE_LENGTH,
DEFAULT_OPTIONS,
Expand Down Expand Up @@ -427,7 +427,7 @@ def _capture_envelope(envelope):
self.monitor
or self.metrics_aggregator
or has_profiling_enabled(self.options)
or isinstance(self.transport, HttpTransport)
or isinstance(self.transport, BaseHttpTransport)
):
# If we have anything on that could spawn a background thread, we
# need to check if it's safe to use them.
Expand Down
Loading
Loading