-
Notifications
You must be signed in to change notification settings - Fork 510
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add httpcore based HTTP2Transport #3588
Conversation
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## master #3588 +/- ##
==========================================
- Coverage 84.35% 84.33% -0.03%
==========================================
Files 133 133
Lines 13929 13994 +65
Branches 2937 2951 +14
==========================================
+ Hits 11750 11802 +52
- Misses 1442 1450 +8
- Partials 737 742 +5
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🥔 Thanks for this. Looks good, left some small comments, please take a look.
Merging this as soon as CI allows. :) |
All our ingest endpoints support HTTP/2 and some even HTTP/3 which are significantly more efficient compared to HTTP/1.1 with multiplexing and, header compression, connection reuse and 0-RTT TLS.
This patch adds an experimental
HTTP2Transport
with the help of httpcore library. It makes minimal changes to the originalHTTPTransport
that said withhttpcore
we should be able to implementasyncio
support easily and remove the worker logic (see #2824).This should also open the door for future HTTP/3 support (see encode/httpx#275).