Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add new SDK overhead page for Apple platforms #12063

Merged
merged 6 commits into from
Dec 12, 2024

Conversation

kahest
Copy link
Member

@kahest kahest commented Dec 6, 2024

DESCRIBE YOUR PR

Adds new "SDK Overhead" menu item + page below the "Mobile SDK Releases" item. Covers Errors etc. in more detail, links to existing product pages for Performance+Profiling+SR.

follow-up to #12031

fixes https://github.com/getsentry/projects/issues/453

Next steps/future work: see https://github.com/getsentry/projects/issues/169

IS YOUR CHANGE URGENT?

Help us prioritize incoming PRs by letting us know when the change needs to go live.

  • Urgent deadline (GA date, etc.):
  • Other deadline: no specific date, target is Dec 11
  • None: Not urgent, can wait up to 1 week+

SLA

  • Teamwork makes the dream work, so please add a reviewer to your PRs.
  • Please give the docs team up to 1 week to review your PR unless you've added an urgent due date to it.
    Thanks in advance for your help!

PRE-MERGE CHECKLIST

Make sure you've checked the following before merging your changes:

  • Checked Vercel preview for correctness, including links
  • PR was reviewed and approved by any necessary SMEs (subject matter experts)
  • PR was reviewed and approved by a member of the Sentry docs team

EXTRA RESOURCES

Copy link

vercel bot commented Dec 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 11, 2024 6:06pm
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
changelog ⬜️ Ignored (Inspect) Visit Preview Dec 11, 2024 6:06pm
develop-docs ⬜️ Ignored (Inspect) Visit Preview Dec 11, 2024 6:06pm

@kahest kahest changed the title adds SDK overhead page for apple platforms chore: Add new SDK overhead page for Apple platforms Dec 6, 2024
Copy link

codecov bot commented Dec 6, 2024

Bundle Report

Changes will increase total bundle size by 168 bytes (0.0%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sentry-docs-server-cjs 10.34MB 174 bytes (0.0%) ⬆️
sentry-docs-client-array-push 9.27MB 6 bytes (-0.0%) ⬇️

Copy link
Member

@philipphofmann philipphofmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor comments.

docs/platforms/apple/common/overhead/index.mdx Outdated Show resolved Hide resolved
Copy link
Contributor

@coolguyzone coolguyzone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for writing this up, looks good to me! 🤙

@kahest kahest merged commit 716b2d4 into master Dec 12, 2024
11 checks passed
@kahest kahest deleted the kahest/apple-sdk-overhead branch December 12, 2024 09:56
Lms24 pushed a commit that referenced this pull request Dec 13, 2024
* adds SDK overhead page for apple platforms

* adds SDK overhead page for apple platforms

* Update docs/platforms/apple/common/overhead/index.mdx

Co-authored-by: Philipp Hofmann <[email protected]>

* update

* update

* Update docs/platforms/apple/common/overhead/index.mdx

Co-authored-by: Alex Krawiec <[email protected]>

---------

Co-authored-by: Philipp Hofmann <[email protected]>
Co-authored-by: Alex Krawiec <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants