Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error when debug file too big to upload #2313

Closed
szokeasaurusrex opened this issue Dec 16, 2024 · 0 comments
Closed

Error when debug file too big to upload #2313

szokeasaurusrex opened this issue Dec 16, 2024 · 0 comments
Assignees

Comments

@szokeasaurusrex
Copy link
Member

szokeasaurusrex commented Dec 16, 2024

There is a file size limit for debug files that are uploaded to Sentry (c.a. 2 GB). When a file exceeds this limit, we log a warning to inform users that the file was skipped:

warn!(
"Skipping debug file since it exceeds {}: {} ({})",
HumanBytes(self.max_file_size),
name,
HumanBytes(file_size.unwrap_or(u64::MAX)),
);

This warning is easy to miss. So, instead of just warning users, we should error and exit with a nonzero status. Our error message can link users to the Symbol Server docs, and also inform them about the ability to set SENTRY_ALLOW_FAILURE to unblock build.

szokeasaurusrex added a commit that referenced this issue Dec 20, 2024
@szokeasaurusrex szokeasaurusrex self-assigned this Jan 2, 2025
szokeasaurusrex added a commit that referenced this issue Jan 2, 2025
Previously, we only logged an easy-to-miss warning when we had to skip uploading a debug file because it was too big. Now, we instead fail the entire upload loudly, to ensure users do not miss this important information.

Resolves #2313
szokeasaurusrex added a commit that referenced this issue Jan 3, 2025
Previously, we only logged an easy-to-miss warning when we had to skip uploading a debug file because it was too big. Now, we instead fail the entire upload loudly, to ensure users do not miss this important information.

Resolves #2313
szokeasaurusrex added a commit that referenced this issue Jan 3, 2025
Previously, we only logged an easy-to-miss warning when we had to skip uploading a debug file because it was too big. Now, we instead fail the entire upload loudly, to ensure users do not miss this important information.

Also, add tests to verify the new behavior.

Resolves #2313
szokeasaurusrex added a commit that referenced this issue Jan 3, 2025
Previously, we only logged an easy-to-miss warning when we had to skip uploading a debug file because it was too big. Now, we instead fail the entire upload loudly, to ensure users do not miss this important information.

Also, add tests to verify the new behavior.

Resolves #2313
szokeasaurusrex added a commit that referenced this issue Jan 7, 2025
Previously, we only logged an easy-to-miss warning when we had to skip uploading a debug file because it was too big. Now, we instead fail the entire upload loudly, to ensure users do not miss this important information.

Also, add tests to verify the new behavior.

Resolves #2313
szokeasaurusrex added a commit that referenced this issue Jan 7, 2025
Previously, we only logged an easy-to-miss warning when we had to skip uploading a debug file because it was too big. Now, we instead fail the entire upload loudly, to ensure users do not miss this important information.

Also, add tests to verify the new behavior.

Resolves #2313
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant