Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normalize URLs before warning about mismatched URL #2310

Open
szokeasaurusrex opened this issue Dec 12, 2024 · 0 comments
Open

Normalize URLs before warning about mismatched URL #2310

szokeasaurusrex opened this issue Dec 12, 2024 · 0 comments

Comments

@szokeasaurusrex
Copy link
Member

If the token-embedded and user-provided URLs only differ by a trailing slash, we should not warn about a mismatched URL.

Let's normalize the URLs before comparing.

Update: discussed with the team. The behavior will likely stay the same in the Sentry Wizard for now due to backwards-compatibility concerns, but we can improve the logic for comparing the URLs in the Sentry CLI. In the meantime, you can safely ignore this warning.

Originally posted by @szokeasaurusrex in #2137

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant