Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only use group in repeat as repeat instance name if it's the repeat's only child #310

Open
lognaturel opened this issue Mar 19, 2024 · 0 comments

Comments

@lognaturel
Copy link
Member

In #141, we decided to recommend that clients use the label of an inner group as a repeat instance label. We were not specific about what to do in case of other contents in the repeat.

#309 makes a clarification of existing behavior in both Collect and Enketo: a group is only used this way if it's the repeat's first child.

In the original issue, we explicitly discussed the case where an inner group is followed by other items in the repeat but not in the group. We decided to still use the first group's label as the repeat instance label. This works ok in the Collect hierarchy view which is what this spec change was designed for.

It doesn't work as well in Enketo where multiple repeat instances are shown on a screen and can be individually collapsed.

Let's only use the inner group label this way if the inner group is the repeat's only child.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant