Features/863 move project description #1121
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sadiqkhoja
commented
Jan 10, 2025
and couple of tests for collapsed view of description
matthew-white
approved these changes
Jan 24, 2025
| @@ -23,7 +23,7 @@ describe('EntityUploadDataTemplate', () => { | |||
| content.should.equal('label,hauteur,circonférence'); | |||
| }); | |||
|
|
|||
| it('has the correct filename', async () => { | |||
| it.skip('has the correct filename', async () => { | |||
There was a problem hiding this comment.
Would be good to revert this before merging.
| onMounted(() => { | ||
| // nextTick is good enough for the calculation being done here. I don't see | ||
| // any screen flicker. Maybe related: https://github.com/vuejs/vue/issues/9200. | ||
| // Additionally Without nextTick offsetHeight is always 0. |
There was a problem hiding this comment.
I bet this is because there's a v-show on <page-head>. Normally I wouldn't expect nextTick() to be needed in onMounted(), since the element is in the DOM at that point. In any case, I think it makes sense the way it is. 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes getodk/central#863
What has been done to verify that this works as intended?
Manually tested it. The visual aspect of this features needs to be thoroughly tested by QA team.
Why is this the best possible solution? Were any other approaches considered?
For now all the calculations are kept inside description component, if need be those can be extracted out to utility module or custom vue directive.
How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
None
Does this change require updates to user documentation? If so, please file an issue here and include the link below.
NA
Before submitting this PR, please make sure you have:
npm run testandnpm run lintand confirmed all checks still pass OR confirm CircleCI build passes