Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Font-awesome: wrong icon for fa-flickr #151

Open
sal0max opened this issue Jul 10, 2020 · 3 comments
Open

Font-awesome: wrong icon for fa-flickr #151

sal0max opened this issue Jul 10, 2020 · 3 comments

Comments

@sal0max
Copy link

sal0max commented Jul 10, 2020

I'm testing grav (v1.6.26) with the quark theme (v2.0.3) since yesterday.
I tried to build a footer like on my old wordpress website: Some internal and external links.

I want to use the font-awesome icons for Instagram, Flickr, Github and RSS.
When using fa-flickr, an icon similar to cart-plus appears, instead of flickr:

grafik

<section id="footer" class="section bg-gray">
    <section class="container grid-lg">
        <p>
            <a href="#">Impressum</a>
            <a href="#"><i class="fa fa-instagram fa-lg"></i></a>
            <a href="#"><i class="fa fa-flickr fa-lg"></i></a>
            <a href="#"><i class="fa fa-github fa-lg"></i></a>
            <a href="#"><i class="fa fa-rss fa-lg"></i></a>
            <a href="#">Datenschutz</a>
        </p>
    </section>
</section>

What could be the reason for this?

@sal0max
Copy link
Author

sal0max commented Jul 12, 2020

Alright, I dug a bit into the issue myself.

Seems quark isn't using Font Awesome, but a fork of Line Awesome. I downloaded fonts/line-awesome.ttf from this repo and also the current line-awesome font from https://icons8.com/line-awesome and installed both on my system.

flickr has the hex code &#xf16e;. I used that hex code inside TextEdit with line-awesome.ttf from this repo and with la-brands-400.ttf from the official download. Here's the result:

grafik

So, it seems the fork of line-awesome which is included with quark, is faulty. Can someone fix that, please?
I'm not familiar, how the line-awesome font was put together, from the different offical fonts.

sal0max added a commit to sal0max/grav-theme-quark that referenced this issue Jul 13, 2020
sal0max added a commit to sal0max/grav-theme-quark that referenced this issue Jul 13, 2020
@NicoHood
Copy link
Contributor

NicoHood commented Oct 7, 2020

@sal0max I just looked at the line awesome/font awesome thing. It seems that quark is not using an old version (fontawesome 4x. compatible), it also uses some non standard fork.

I guess the best way would to upgrade quark to line awesome 1.3.0 which is compatible with fontawesome 5.x. But that requires a few changes and will be a breaking change.

@NicoHood
Copy link
Contributor

I've added full line-awesome 1.3.0 support (with font-awesome 4&5 compatibility!!!) here (and other changes): https://github.com/NicoHood/grav-theme-quark/tree/magerquark

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants