Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump bigdecimal from 0.3.1 to 0.4.1 #1801

Closed
wants to merge 1 commit into from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jul 27, 2023

Bumps bigdecimal from 0.3.1 to 0.4.1.

Release notes

Sourced from bigdecimal's releases.

v0.4.1

Changes

  • Fix issue where RUST_BIGDECIMAL_DEFAULT_PRECISION envar would always trigger a rebuild

  • Fix issue where .neg() could be called on {signed-int}::MIN values

  • Add implementations of Add/Sub/Mul/Div for primitive values

  • Use 'proptest' crate to improve arithmetic testing

v0.4.0

Changes

  • no_std feature support akubera/bigdecimal-rs#97

    • To disable std, change your Cargo.toml dependency to:
      bigdecimal = { version = "0.4", default-features = false }
    • Still depends on alloc (I think we will always need dynamic storage)
  • Allow user to set default max-precision at compile time

    • Use environment variable RUST_BIGDECIMAL_DEFAULT_PRECISION
    • Defaults to 100
    • This "is the number of 3s in calculation of 1/3"
    • Better solutions are being considered
      • This is tricky: Do we set a global variable? Do we require every math operation to specify precision? Do we store precision in each BigDecimal? Is that set from a global variable? Should we use macros to balance explicit precision and tidy code?
  • Add rounding module with RoundingMode enum

    • Used in new method: BigDecimal::with_scale_round
    • Finally, you can truncate your decimal with the rounding you prefer!
    • Will be coming to more methods, soon
  • Reimplement parsing from {32,64}-bit float values

  • Bump Minimum Supported Rust Version from 1.34 to 1.43

    • Was breaking a few test dependencies
    • Able to do more at compile time
    • Probably wont affect too many people?
  • Fix implementations of to_u128/to_i128 akubera/bigdecimal-rs#101

    • Default implementations cast values to 64 bit ints
  • Fix issue where underscores after the decimal counted towards total digit count (giving wrong exponent) akubera/bigdecimal-rs#99

  • Fix case of panic during rounding akubera/bigdecimal-rs#90

  • Add preliminary benchmarking code

    • Unsatisfied with statistics: more work to be done with Criterion
    • Eventually get some answers on how best to parse strings, and in what format should the digits be stored
  • Started using my crazy approach to unit testing

Commits
  • f450e54 Release v0.4.1
  • 1fc48f5 Version 0.4.1
  • ccb6ccf Add alternative implementation of Div<int> for older versions
  • 208831c Add autocfg to probe rust version
  • 3510870 Pin serde json to 1.0.96
  • 72bcd83 Merge proptest support into trunk
  • 33232ce Enable property tests in gitlab-ci.yml
  • 1d4f1d8 Add property-tests file
  • 6515af3 Add support for proptests
  • 65f9f8f Fix some rustfmt issues
  • Additional commits viewable in compare view

Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Note
Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

Bumps [bigdecimal](https://github.com/akubera/bigdecimal-rs) from 0.3.1 to 0.4.1.
- [Release notes](https://github.com/akubera/bigdecimal-rs/releases)
- [Commits](akubera/bigdecimal-rs@v0.3.1...v0.4.1)

---
updated-dependencies:
- dependency-name: bigdecimal
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@chubei
Copy link
Contributor

chubei commented Sep 26, 2023

@dependabot rebase

@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Sep 26, 2023

Looks like bigdecimal is no longer updatable, so this is no longer needed.

@dependabot dependabot bot closed this Sep 26, 2023
@dependabot dependabot bot deleted the dependabot/cargo/bigdecimal-0.4.1 branch September 26, 2023 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants