From 3642fdc10e55b2276fba5d0c013e093d47e09705 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Karolis=20Gudi=C5=A1kis?= <karolisgud@gmail.com>
Date: Thu, 4 Apr 2024 15:17:40 +0530
Subject: [PATCH] feat: Enable string types (#2475)

* feat: Use nvarchar2

* Use chars
---
 dozer-ingestion/oracle/src/connector/mapping.rs | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/dozer-ingestion/oracle/src/connector/mapping.rs b/dozer-ingestion/oracle/src/connector/mapping.rs
index 718dce3349..e109cbbbfa 100644
--- a/dozer-ingestion/oracle/src/connector/mapping.rs
+++ b/dozer-ingestion/oracle/src/connector/mapping.rs
@@ -52,7 +52,7 @@ fn map_data_type(
     } else {
         match data_type {
             "VARCHAR2" => Ok(FieldType::String),
-            "NVARCHAR2" => unimplemented!("convert NVARCHAR2 to String"),
+            "NVARCHAR2" => Ok(FieldType::String),
             "INTEGER" => Ok(FieldType::I128),
             "NUMBER" => match (precision, scale) {
                 (Some(precision), Some(0)) if precision <= 19 => Ok(FieldType::Int),
@@ -66,9 +66,9 @@ fn map_data_type(
             "RAW" => Ok(FieldType::Binary),
             "ROWID" => Ok(FieldType::String),
             "CHAR" => Ok(FieldType::String),
-            "NCHAR" => unimplemented!("convert NCHAR to String"),
+            "NCHAR" => Ok(FieldType::String),
             "CLOB" => Ok(FieldType::String),
-            "NCLOB" => unimplemented!("convert NCLOB to String"),
+            "NCLOB" => Ok(FieldType::String),
             "BLOB" => Ok(FieldType::Binary),
             other => Err(DataTypeError::UnsupportedDataType(other.to_string())),
         }?