You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
To ensure contributions to this open source project one thing we must do is make sure we set some standards and best practices or follow some conventional standards and best practices. This makes it easier for outside developers to understand and makes it easier to contribute since what they're seeing is what can be expected from an Android/Kotlin project.
Today DiskUsageViewModel implements HealthMetricProvider. We should decouple this and instead have a DiskUsageHealthMetric class that implements the HealthMetricProvider interface. Or use the use case to return a Disk Usage HealthMetric.
We should also update the GetDiskUsageMetrics use case to match the format that is expected of use cases.
Rename the file/class to GetDiskUsageMetricsUseCase
Use cases should have only one public method, refactor to make anything else private
Rename public method to have the signature operator fun invoke(...): HealthMetric to keep things consistent among use cases
The text was updated successfully, but these errors were encountered:
To ensure contributions to this open source project one thing we must do is make sure we set some standards and best practices or follow some conventional standards and best practices. This makes it easier for outside developers to understand and makes it easier to contribute since what they're seeing is what can be expected from an Android/Kotlin project.
Today
DiskUsageViewModel
implementsHealthMetricProvider
. We should decouple this and instead have aDiskUsageHealthMetric
class that implements theHealthMetricProvider
interface. Or use the use case to return a Disk UsageHealthMetric
.We should also update the
GetDiskUsageMetrics
use case to match the format that is expected of use cases.GetDiskUsageMetricsUseCase
operator fun invoke(...): HealthMetric
to keep things consistent among use casesThe text was updated successfully, but these errors were encountered: