diff --git a/.github/workflows/cloudformation-validation.yml b/.github/workflows/cloudformation-validation.yml index 21af2c9..6f5530f 100644 --- a/.github/workflows/cloudformation-validation.yml +++ b/.github/workflows/cloudformation-validation.yml @@ -15,12 +15,14 @@ jobs: steps: - uses: actions/checkout@v4 - - name: CloudFormation-Validation + - name: CloudFormation Template Validation run: | pip install awscli - pip install cfn-lint aws cloudformation validate-template --template-body file://2-zone-vpc-cf-template.yml --region us-east-1 - cfn-lint 2-zone-vpc-cf-template.yml env: AWS_ACCESS_KEY_ID: ${{ secrets.AWS_ACCESS_KEY_ID }} AWS_SECRET_ACCESS_KEY: ${{ secrets.AWS_SECRET_ACCESS_KEY }} + - name: CloudFormation Linter + run: | + pip install cfn-lint + cfn-lint -I 2-zone-vpc-cf-template.yml diff --git a/2-zone-vpc-cf-template.yml b/2-zone-vpc-cf-template.yml index 88c4cc2..d01193a 100644 --- a/2-zone-vpc-cf-template.yml +++ b/2-zone-vpc-cf-template.yml @@ -191,8 +191,6 @@ Resources: Ref: 'Environment' RoutePublicZoneA: - DependsOn: - - InternetGateway Type: AWS::EC2::Route Properties: DestinationCidrBlock: '0.0.0.0/0' @@ -202,8 +200,6 @@ Resources: Ref: 'RouteTablePublicZoneA' RoutePublicZoneB: - DependsOn: - - InternetGateway Type: AWS::EC2::Route Properties: DestinationCidrBlock: 0.0.0.0/0