Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add external id and name/description fields to Rule and AdminRule #244

Open
groldan opened this issue Mar 10, 2023 · 1 comment
Open

Add external id and name/description fields to Rule and AdminRule #244

groldan opened this issue Mar 10, 2023 · 1 comment
Labels

Comments

@groldan
Copy link
Member

groldan commented Mar 10, 2023

I'd like to add an extId property to Rule and AdminRule, just like GSUser.extId.

Additional, it'd be nice to have name and/or description properties.

Use case is I've access rules defined in an external system that are converted to GeoFence rules.
The external id would help identify which external system rule corresponds to each GeoFence rule, while
currently I've to fetch them all, and use a SHA-family hash to determine which rules have changed.

The name/description fields are a secondary concern, but nice to have in order to visually correlate them
in a human friendly way at GeoServer's rules web ui pages.

comments?

@etj
Copy link
Member

etj commented Mar 13, 2023

+1 about the extId, it would improve integrations with external systems. The field in the users model was used exactly for that purpose.

I'm not sure about the description field tho: the Rule class is at the core of the engine and at the moment only contains fields for searching/filtering; adding a field for human interaction may add overhead and would probably be unneeded most of the time. Maybe adding a 1:1 object for extra info to be loaded from the DB on demand only would be a nicer place to put such info; that object could in the future grow to hold more informative fields not related to the filtering.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants