Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update dependencies, fix all clippy lints #48

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

elwerene
Copy link
Contributor

No description provided.

@urschrei
Copy link
Member

lgtm.

@urschrei
Copy link
Member

bors try

bors bot added a commit that referenced this pull request Aug 11, 2021
@michaelkirk
Copy link
Member

I think CI is blocked on #49

src/geoadmin.rs Outdated Show resolved Hide resolved
@elwerene
Copy link
Contributor Author

cargo test does not go through on my machine, but also not in master :/

@urschrei
Copy link
Member

Hi @elwerene, I've probably caused some conflicts in Cargo.toml – apologies. If you rebase against master and accept them your PR should pass tests and we can merge.

@bors
Copy link
Contributor

bors bot commented Aug 17, 2021

try

Timed out.

@elwerene
Copy link
Contributor Author

@urschrei I just fixed the conflicts

@elwerene elwerene requested a review from michaelkirk August 18, 2021 07:07
src/geoadmin.rs Outdated Show resolved Hide resolved
@michaelkirk
Copy link
Member

bors try

bors bot added a commit that referenced this pull request Aug 18, 2021
@bors
Copy link
Contributor

bors bot commented Aug 18, 2021

try

Build succeeded:

@elwerene
Copy link
Contributor Author

bors try

@bors
Copy link
Contributor

bors bot commented Aug 18, 2021

🔒 Permission denied

Existing reviewers: click here to make elwerene a reviewer

@lnicola
Copy link
Member

lnicola commented Aug 18, 2021

bors try

@bors
Copy link
Contributor

bors bot commented Aug 18, 2021

🔒 Permission denied

Existing reviewers: click here to make lnicola a reviewer

@urschrei
Copy link
Member

Existing reviewers: click here to make lnicola a reviewer

try again!

@lnicola
Copy link
Member

lnicola commented Aug 18, 2021

bors try

bors bot added a commit that referenced this pull request Aug 18, 2021
@bors
Copy link
Contributor

bors bot commented Aug 18, 2021

try

Build succeeded:

@michaelkirk
Copy link
Member

Hi @elwerene - sorry that this sat so long. Can you explain why you made the most recent change? f71c2a1

@lnicola
Copy link
Member

lnicola commented Nov 29, 2021

Is it rust-lang/cargo#3494 again? 😄

@elwerene
Copy link
Contributor Author

No, I accidently set the wrong feature before and it wasn't possible to use rustls without defaultls. Now it's just an update without changing the tls feature behavior.
maybe it's the mentioned cargo issue? I'm too tired to understand it atm :)
Maybe tomorrow..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants