CI failing after cargo update

[michaelkirk]

https://github.com/georust/geo/actions/runs/11689401597/job/32552055508

Failure is in concave hull.

[michaelkirk]

Notably, tests pass if I pin to the previous rstar

- rstar = "0.12.0"
+ rstar = "=0.12.0"

(latest version is 0.12.1)

Still investigating...

[michaelkirk]

Failing test: concave_hull_norway_test

let actual  = res.exterior();
let expected = norway_concave_hull;

actual wkt

LINESTRING(5.227792433014884 59.468030338041025,5.23044532188834 59.45613831272054,5.2384039885087095 59.432354262079556,5.249015544002534 59.432354262079556,5.48777554261359 58.75186614651813,5.503692875854327 58.743938129637804,5.519610209095064 58.72015407899682,5.516957320221608 58.70958338982305,5.538180431209257 58.671264641568136,5.551444875576538 58.656729943954204,5.572667986564188 58.648801927073876,5.625725764033311 58.59330580891158,5.6389902084005925 58.584056455884536,5.649601763894417 58.55498706065667,5.70265954136354 58.53516701845585,5.726535541224646 58.53516701845585,5.782246207567226 58.5008122786411,5.787551985314138 58.49024158946733,5.824692429542525 58.482313572587,5.861832873770911 58.47174288341323,5.8777502070116485 58.46381486653291,5.99447731744372 58.41888943754438,6.005088872937545 58.41096142066406,6.015700428431369 58.40303340378373,6.023659095051738 58.38849870616979,6.0501879837863 58.37528534470258,6.068758205900493 58.37264267240914,6.100592872381967 58.37132133626242,6.100592872381967 58.36075064708865,6.169567983091828 58.33828793259439,6.249154649295513 58.322431898833734,6.26507198253625 58.319789226540294,6.315476871131918 58.30921853736652,6.323435537752286 58.30129052048619,6.336699982119567 58.289398495165706,6.368534648601042 58.277506469845214,6.381799092968322 58.27354246140505,6.41098087057634 58.266935780671446,6.424245314943621 58.289398495165706,6.4322039815639895 58.28543448672554,6.461385759172008 58.269578452964886,6.456079981425095 58.26297177223128,6.477303092412745 58.255043755350954,6.493220425653481 58.25240108305751,6.519749314388044 58.25900776379112,6.525055092134956 58.247115738470626,6.554236869742974 58.11894613223867,6.55688975861643 58.11101811535834,6.596683091718273 58.08459139242392,6.620559091579379 58.07402070325014,6.639129313693571 58.06609268636982,6.660352424681221 58.07666337554359,6.694839980036152 58.06609268636982,6.713410202150344 58.06873535866326,6.763815090746013 58.0647713502231,6.771773757366381 58.072699367103425,6.771773757366381 58.077984711690306,6.79299686835403 58.0647713502231,6.785038201733661 58.05420066104933,7.02910397809163 57.99474053444687,7.034409755838542 58.00398988747392,7.055632866826192 57.97888450068622,7.076855977813841 57.98681251756655,7.108690644295315 58.005311223620645,7.113996422042227 58.01588191279441,7.121955088662596 58.02513126582146,7.124607977536052 58.03834462728867,7.140525310776789 58.05420066104933,7.148483977397158 58.050236652609165,7.156442644017527 58.04362997187556,7.169707088384808 58.0396659634354,7.20950042148665 58.030416610408345,7.2227648658539305 58.03173794655507,7.243987976841581 58.04362997187556,7.267863976702686 58.04759398031572,7.275822643323055 58.04362997187556,7.278475532196511 58.027773938114905,7.318268865298354 58.02513126582146,7.33418619853909 58.027773938114905,7.3819381982613015 58.01720324894113,7.403161309248951 58.005311223620645,7.419078642489688 58.02380992967474,7.429690197983513 58.01588191279441,7.456219086718074 58.01984592123458,7.498665308693374 58.005311223620645,7.517235530807566 58.005311223620645,7.549070197289041 58.00927523206081,7.575599086023603 58.007953895914085,7.583557752643971 57.99870454288703,7.594169308137796 58.00927523206081,7.6206981968723575 58.007953895914085,7.631309752366183 58.01720324894113,7.668450196594569 58.01323924050097,7.7825244181531845 58.06609268636982,7.79313597364701 58.06609268636982,7.817011973508115 58.06609268636982,7.838235084495764 58.0647713502231,7.84088797336922 58.07402070325014,7.8568053066099575 58.070056694809985,7.875375528724151 58.072699367103425,7.915168861825993 58.070056694809985,7.9443506394340115 58.07666337554359,7.949656417180924 58.07402070325014,7.976185305915486 58.08723406471736,7.978838194788942 58.10309009847801,7.970879528168574 58.114982123798505,7.978838194788942 58.126874149119,7.997408416903135 58.12951682141244,8.013325750143872 58.130838157559154,8.034548861131523 58.14537285517309,8.047813305498803 58.14537285517309,8.058424860992627 58.137444838292765,8.058424860992627 58.12291014067883,8.063730638739539 58.11894613223867,8.087606638600645 58.1334808298526,8.087606638600645 58.12158880453211,8.130052860575944 58.12158880453211,8.124747082829032 58.108375443064894,8.135358638322856 58.10309009847801,8.15392886043705 58.10705410691818,8.206986637906173 58.11233945150506,8.217598193399997 58.12158880453211,8.241474193261103 58.12555281297227,8.257391526501841 58.1334808298526,11.525750618599853 58.876071744309925,11.539015062967135 58.88003575275009,11.570849729448607 58.88796376963042,11.573502618322063 58.89589178651074,11.589419951562801 58.89060644192386,11.6318661735381 58.909105147977954,11.650436395652292 58.90646247568451,30.9316327279318 69.55907449055096,30.94755006117254 69.57493052431161,30.93959139455217 69.59475056651243,30.950202950045995 69.60003591109931,30.95285583891945 69.6304266424739,30.944897172299083 69.68328008834276,30.928979839058343 69.68460142448947,30.92367406131143 69.66874539072882,31.06427717160461 70.28845204354107,31.061624282731152 70.32016411106238,31.045706949490416 70.33337747252959,31.053665616110784 70.36112553161074,31.037748282870048 70.3901949268386,30.995302060894748 70.41926432206647,30.96081450553982 70.42983501124024,30.955508727792907 70.44304837270745,30.926326950184887 70.44965505344106,30.634509174104707 70.54479125600498,30.61328606311706 70.55271927288531,30.207394065478265 70.67428219838366,30.178212287870245 70.68353155141071,30.101278510540016 70.6954235767312,30.08536117729928 70.7073156020517,30.011080288842507 70.71127961049186,29.94741095587956 70.70335159361153,29.920882067144998 70.68617422370416,29.904964733904258 70.68353155141071,29.812113623333293 70.69410224058448,29.80150206783947 70.72449297195907,29.71660962388887 70.73506366113284,29.27357718202169 70.8262358552566,29.24970118216058 70.83680654443037,29.247048293287126 70.84605589745742,29.201949182438373 70.85398391433775,29.132974071728512 70.84869856975087,29.093180738626668 70.85794792277791,29.09052784975321 70.87380395653857,29.05073451665137 70.87380395653857,28.992370961435334 70.8698399480984,28.976453628194598 70.88569598185906,28.83585051790142 70.87776796497873,28.750958073950823 70.85398391433775,28.549338519568153 70.96761882295577,28.54403274182124 70.97951084827626,28.52280963083359 70.98743886515659,28.408735409274975 71.00329489891725,28.305272743210182 71.00329489891725,28.284049632222533 70.99140287359675,28.26547941010834 71.04822032790577,28.24690918799415 71.08521774001396,28.191198521651568 71.09578842918773,28.156710966296636 71.09182442074757,28.130182077562075 71.0812537315738,28.06385985572567 71.0878604123074,28.018760744876918 71.07728972313363,27.98162030064853 71.08521774001396,27.963050078534337 71.06143368937298,27.7534718575313 71.10900179065494,27.708372746682542 71.11296579909511,27.644703413719593 71.13278584129593,27.628786080478857 71.1248578244156,27.57838119188319 71.10768045450823,27.551852303148628 71.10503778221478,27.54389363652826 71.09578842918773,27.50144741455296 71.08521774001396,27.498794525679504 71.04029231102544,27.427166526096187 71.02443627726478,27.374108748627066 71.01386558809102,27.37145585975361 71.02443627726478,27.31574519341103 71.03236429414511,27.275951860309185 71.0442563194656,27.212282527346236 71.02840028570495,27.199018082978956 71.01386558809102,26.70558075251611 70.96629748680905,26.671093197161177 70.97026149524922,26.63660564180625 70.95572679763528,26.567630531096388 70.95176278919512,26.511919864753807 70.93458541928774,26.437638976297034 70.90155201561971,26.42702742080321 70.89230266259267,26.400498532068646 70.8883386541525,25.86992075737741 70.84869856975087,25.904408312732343 70.86455460351152,25.909714090479255 70.87380395653857,25.88318520174469 70.89362399873939,25.84339186864285 70.90155201561971,25.742582091451514 70.88965999029922,25.713400313843497 70.89626667103283,25.708094536096585 70.90551602405988,25.647078092007092 70.90551602405988,25.607284758905248 70.9068373602066,25.548921203689215 70.9134440409402,25.511780759460827 70.92269339396725,25.50912787058737 70.93062141084758,25.448111426497878 70.94647744460823,25.437499871004054 70.95969080607544,25.379136315788017 70.96761882295577,25.355260315926913 70.9636548145156,25.34995453818 70.97422550368938,25.312814093951612 70.97422550368938,25.299549649584332 70.96233347836889,25.04487231773254 70.95440546148856,25.01038476237761 70.97158283139593,24.959979873781943 70.96233347836889,24.957326984908487 70.9755468398361,24.77427765264001 70.99008153745004,24.73979009728508 70.99008153745004,24.69734387530978 70.97158283139593,24.69734387530978 70.99008153745004,24.67081498657522 70.96761882295577,24.625715875726463 70.99008153745004,24.59388120924499 70.97951084827626,24.57265809825734 70.96233347836889,24.543476320649322 70.95440546148856,24.535517654028954 70.97026149524922,21.56693500463149 70.31355743032877,21.564282115758033 70.32412811950255,21.487348338427804 70.30959342188861,21.471431005187068 70.29770139656812,21.415720338844487 70.27391734592713,21.367968339122275 70.26466799290009,21.34409233926117 70.26466799290009,21.296340339538958 70.25673997601976,21.24062967319638 70.23691993381894,21.23532389544947 70.2408839422591,21.20614211784145 70.22370657235173,21.190224784600712 70.21974256391157,21.1849190068538 70.19992252171075,20.31742434523363 69.96472468759437,20.285589678752157 69.97661671291486,20.256407901144136 69.97529537676814,20.256407901144136 69.96472468759437,20.203350123675015 69.94094063695339,20.16355679057317 69.9356552923665,20.155598123952803 69.94358330924683,20.129069235218243 69.9356552923665,19.731135904199814 69.80748568613454,19.723177237579446 69.77841629090668,19.67011946011032 69.81541370301487,19.593185682780092 69.80484301384111,19.545433683057883 69.80087900540094,19.502987461082583 69.79691499696078,19.447276794740002 69.78238029934684,19.42870657262581 69.786344307787,19.39421901727088 69.77709495475996,19.322591017687564 69.77841629090668,19.293409240079544 69.7731309463198,19.272186129091896 69.77841629090668,19.195252351761667 69.7612389209993,19.174029240774015 69.74538288723865,19.144847463166 69.74141887879848,19.134235907672174 69.7480255595321,19.097095463443786 69.73349086191816,18.23490657957053 69.4811156578944,18.232253690697075 69.46658096028047,18.189807468721774 69.45997427954687,18.152667024493386 69.46525962413375,18.131443913505738 69.45336759881326,15.627116816963106 68.19017024254778,15.62446392808965 68.17431420878712,15.592629261608174 68.18092088952073,15.515695484277945 68.14920882199942,15.475902151176104 68.15317283043959,15.412232818213155 68.14260214126581,15.391009707225507 68.13071011594532,15.34591059637675 68.1042833930109,15.314075929895278 68.07653533392975,15.298158596654538 68.06464330860926,15.27693548566689 68.0606793001691,15.279588374540346 68.04482326640844,14.900225265636113 67.8862629288019,14.879002154648465 67.87701357577485,14.849820377040444 67.85455086128059,14.828597266052796 67.8611575420142,14.802068377318236 67.84133749981338,14.78349815520404 67.82548146605272,14.77023371083676 67.82944547449289,13.555210606793828 66.94547159233639,13.544599051300004 66.93225823086918,13.536640384679636 66.94018624774951,13.281963052827845 66.73273647271428,13.268698608460564 66.71688043895362,13.25543416409328 66.71291643051346,13.223599497611808 66.67724035455198,13.197070608877247 66.6719550099651,13.165235942395771 66.65742031235116,13.024632832102593 66.52792936997248,12.995451054494577 66.53189337841265,12.971575054633469 66.5226440253856,9.676687073800895 63.844295655981696,9.666075518307071 63.83372496680793,9.663422629433615 63.82315427763416,9.634240851825599 63.829760958367764,9.623629296331773 63.81522626075383,9.607711963091035 63.799370226993176,9.607711963091035 63.79144221011285,9.589141740976842 63.787478201672684,9.562612852242282 63.77294350405875,9.244266187427538 63.52321097232844,9.231001743060258 63.51660429159483,9.217737298692978 63.515282955448114,9.201819965452241 63.50339093012762,9.167332410097309 63.482249551780086,9.14610929910966 63.48621356022025,9.02938218867759 63.44657347581861,9.00020041106957 63.447894811965334,8.971018633461552 63.439966795085006,8.93122530035971 63.425432097471074,8.907349300498606 63.39504136609648,8.90469641162515 63.408254727563694,8.8834733006375 63.40957606371042,8.878167522890585 63.417504080590746,8.848985745282569 63.425432097471074,8.817151078801094 63.42939610591124,8.740217301470866 63.41354007215058,8.732258634850496 63.42146808903091,8.711035523862847 63.417504080590746,8.660630635267179 63.40957606371042,8.647366190899898 63.40164804683009,8.644713302026442 63.3897560215096,7.978838194788942 63.088491380057164,7.968226639295118 63.080563363176836,7.915168861825993 63.04224461492192,7.885987084217976 63.023745908867824,7.718855085190237 62.970892462998975,7.68171464096185 62.96692845455881,7.588863530390883 62.92464569786373,7.583557752643971 62.93653772318422,7.564987530529778 62.92464569786373,7.517235530807566 62.906146991809635,7.485400864326093 62.906146991809635,7.469483531085356 62.89821897492931,7.448260420097706 62.906146991809635,7.456219086718074 62.92068168942357,7.442954642350793 62.93653772318422,7.416425753616232 62.94842974850471,7.413772864742776 62.95503642923832,7.384591087134758 62.95900043767848,7.376632420514389 62.96692845455881,7.331533309665634 62.973535135292416,7.323574643045266 62.98939116905307,7.286434198816879 62.9788204798793,7.278475532196511 62.98939116905307,7.283781309943423 62.99996185822684,7.246640865715037 62.98939116905307,7.236029310221212 62.99996185822684,7.20950042148665 62.993355177493235,7.17501286613172 62.993355177493235,7.151136866270614 62.9973191859334,7.151136866270614 62.98542716061291,7.100731977674947 62.961643109971924,7.090120422181122 62.95900043767848,7.060938644573104 62.970892462998975,7.021145311471262 62.95239375694487,6.922988423153383 62.91407500868996,6.9070710899126455 62.90218298336947,6.89645953441882 62.9101110002498,5.325949321332763 62.167520085792475,5.299420432598201 62.1569493966187,5.294114654851289 62.17148409423264,5.280850210484008 62.1754481026728,5.249015544002534 62.17809077496624,5.227792433014884 62.1939468087269,5.225139544141428 62.20848150634083,5.209222210900691 62.205838834047384,5.180040433292673 62.21376685092771,5.177387544419217 62.1939468087269,5.14024710019083 62.2005534894605,5.097800878215532 62.1939468087269,5.095147989342076 62.18337611955313,5.095147989342076 62.16619874964575,5.103106655962444 62.14902137973837,5.113718211456269 62.12655866524412,5.116371100329725 62.10013194230969,4.991685323277284 61.7394071742548,4.983726656656916 61.72883648508103,4.98107376778346 61.72487247664087,4.970462212289635 61.71298045132038,4.970462212289635 61.68258971994579,4.970462212289635 61.6706976946253,4.989032434403828 61.625772265636776,4.9943382121507405 61.59802420655563,4.9969911010241965 61.580846836648256,4.973115101163091 61.41700115445482,4.9943382121507405 61.40510912913433,4.98107376778346 61.2848675397827,4.98107376778346 61.26108348914172,4.9943382121507405 61.25051279996795,5.007602656518022 61.24258478308762,5.007602656518022 61.224086077033526,5.010255545391478 61.22012206859336,4.949239101301986 60.807865190816344,4.965156434542723 60.79597316549585,5.227792433014884 59.51691977546972,5.222486655267972 59.50106374170906,5.227792433014884 59.468030338041025)

expected wkt

LINESTRING(5.227792433014884 59.468030338041025,5.23044532188834 59.45613831272054,5.2384039885087095 59.432354262079556,5.249015544002534 59.432354262079556,5.48777554261359 58.75186614651813,5.503692875854327 58.743938129637804,5.519610209095064 58.72015407899682,5.516957320221608 58.70958338982305,5.538180431209257 58.671264641568136,5.551444875576538 58.656729943954204,5.572667986564188 58.648801927073876,5.625725764033311 58.59330580891158,5.6389902084005925 58.584056455884536,5.649601763894417 58.55498706065667,5.70265954136354 58.53516701845585,5.726535541224646 58.53516701845585,5.782246207567226 58.5008122786411,5.787551985314138 58.49024158946733,5.824692429542525 58.482313572587,5.861832873770911 58.47174288341323,5.8777502070116485 58.46381486653291,5.99447731744372 58.41888943754438,6.005088872937545 58.41096142066406,6.015700428431369 58.40303340378373,6.023659095051738 58.38849870616979,6.0501879837863 58.37528534470258,6.068758205900493 58.37264267240914,6.100592872381967 58.37132133626242,6.100592872381967 58.36075064708865,6.169567983091828 58.33828793259439,6.249154649295513 58.322431898833734,6.26507198253625 58.319789226540294,6.315476871131918 58.30921853736652,6.323435537752286 58.30129052048619,6.336699982119567 58.289398495165706,6.368534648601042 58.277506469845214,6.381799092968322 58.27354246140505,6.41098087057634 58.266935780671446,6.554236869742974 58.11894613223867,6.55688975861643 58.11101811535834,6.596683091718273 58.08459139242392,6.620559091579379 58.07402070325014,6.639129313693571 58.06609268636982,6.660352424681221 58.07666337554359,6.694839980036152 58.06609268636982,6.713410202150344 58.06873535866326,6.763815090746013 58.0647713502231,6.771773757366381 58.077984711690306,6.771773757366381 58.072699367103425,6.785038201733661 58.05420066104933,6.79299686835403 58.0647713502231,6.816872868215135 58.0647713502231,6.891153756671908 58.070056694809985,6.9097239787861024 58.07666337554359,6.920335534279927 58.072699367103425,6.933599978647207 58.06080734178293,6.93890575639412 58.050236652609165,6.960128867381769 58.04759398031572,6.984004867242875 58.027773938114905,7.015839533724349 58.03438061884851,7.037062644711998 58.02116725738129,7.034409755838542 58.00398988747392,7.02910397809163 57.99474053444687,7.055632866826192 57.97888450068622,7.076855977813841 57.98681251756655,7.108690644295315 58.005311223620645,7.113996422042227 58.01588191279441,7.121955088662596 58.02513126582146,7.124607977536052 58.03834462728867,7.140525310776789 58.05420066104933,7.148483977397158 58.050236652609165,7.156442644017527 58.04362997187556,7.169707088384808 58.0396659634354,7.20950042148665 58.030416610408345,7.2227648658539305 58.03173794655507,7.243987976841581 58.04362997187556,7.267863976702686 58.04759398031572,7.275822643323055 58.04362997187556,7.278475532196511 58.027773938114905,7.318268865298354 58.02513126582146,7.33418619853909 58.027773938114905,7.3819381982613015 58.01720324894113,7.403161309248951 58.005311223620645,7.419078642489688 58.02380992967474,7.429690197983513 58.01588191279441,7.456219086718074 58.01984592123458,7.498665308693374 58.005311223620645,7.517235530807566 58.005311223620645,7.549070197289041 58.00927523206081,7.575599086023603 58.007953895914085,7.583557752643971 57.99870454288703,7.594169308137796 58.00927523206081,7.6206981968723575 58.007953895914085,7.631309752366183 58.01720324894113,7.668450196594569 58.01323924050097,7.7825244181531845 58.06609268636982,7.79313597364701 58.06609268636982,7.817011973508115 58.06609268636982,7.838235084495764 58.0647713502231,7.84088797336922 58.07402070325014,7.8568053066099575 58.070056694809985,7.875375528724151 58.072699367103425,7.915168861825993 58.070056694809985,7.9443506394340115 58.07666337554359,7.949656417180924 58.07402070325014,7.976185305915486 58.08723406471736,8.124747082829032 58.108375443064894,8.135358638322856 58.10309009847801,8.15392886043705 58.10705410691818,8.206986637906173 58.11233945150506,8.217598193399997 58.12158880453211,8.241474193261103 58.12555281297227,8.257391526501841 58.1334808298526,11.525750618599853 58.876071744309925,11.539015062967135 58.88003575275009,11.570849729448607 58.88796376963042,11.573502618322063 58.89589178651074,11.589419951562801 58.89060644192386,11.6318661735381 58.909105147977954,11.650436395652292 58.90646247568451,30.9316327279318 69.55907449055096,30.94755006117254 69.57493052431161,30.93959139455217 69.59475056651243,30.950202950045995 69.60003591109931,30.95285583891945 69.6304266424739,30.944897172299083 69.68328008834276,30.928979839058343 69.68460142448947,30.92367406131143 69.66874539072882,31.06427717160461 70.28845204354107,31.061624282731152 70.32016411106238,31.045706949490416 70.33337747252959,31.053665616110784 70.36112553161074,31.037748282870048 70.3901949268386,30.995302060894748 70.41926432206647,30.96081450553982 70.42983501124024,30.955508727792907 70.44304837270745,30.926326950184887 70.44965505344106,30.634509174104707 70.54479125600498,30.61328606311706 70.55271927288531,30.207394065478265 70.67428219838366,30.178212287870245 70.68353155141071,30.101278510540016 70.6954235767312,30.08536117729928 70.7073156020517,30.011080288842507 70.71127961049186,29.94741095587956 70.70335159361153,29.920882067144998 70.68617422370416,29.904964733904258 70.68353155141071,29.812113623333293 70.69410224058448,29.80150206783947 70.72449297195907,29.71660962388887 70.73506366113284,29.27357718202169 70.8262358552566,29.24970118216058 70.83680654443037,29.247048293287126 70.84605589745742,29.201949182438373 70.85398391433775,29.132974071728512 70.84869856975087,29.093180738626668 70.85794792277791,29.09052784975321 70.87380395653857,29.05073451665137 70.87380395653857,28.992370961435334 70.8698399480984,28.976453628194598 70.88569598185906,28.83585051790142 70.87776796497873,28.750958073950823 70.85398391433775,28.459140297870643 70.87644662883201,28.47505763111138 70.88965999029922,28.48832207547866 70.90551602405988,28.50954518646631 70.9134440409402,28.549338519568153 70.96761882295577,28.54403274182124 70.97951084827626,28.52280963083359 70.98743886515659,28.408735409274975 71.00329489891725,28.305272743210182 71.00329489891725,28.284049632222533 70.99140287359675,28.26547941010834 71.04822032790577,28.24690918799415 71.08521774001396,28.191198521651568 71.09578842918773,28.156710966296636 71.09182442074757,28.130182077562075 71.0812537315738,28.06385985572567 71.0878604123074,28.018760744876918 71.07728972313363,27.98162030064853 71.08521774001396,27.963050078534337 71.06143368937298,27.7534718575313 71.10900179065494,27.708372746682542 71.11296579909511,27.644703413719593 71.13278584129593,27.628786080478857 71.1248578244156,27.57838119188319 71.10768045450823,27.551852303148628 71.10503778221478,27.54389363652826 71.09578842918773,27.50144741455296 71.08521774001396,27.37145585975361 71.02443627726478,27.374108748627066 71.01386558809102,27.31574519341103 71.03236429414511,27.275951860309185 71.0442563194656,27.212282527346236 71.02840028570495,27.199018082978956 71.01386558809102,26.70558075251611 70.96629748680905,26.671093197161177 70.97026149524922,26.63660564180625 70.95572679763528,26.567630531096388 70.95176278919512,26.511919864753807 70.93458541928774,25.909714090479255 70.87380395653857,25.904408312732343 70.86455460351152,25.88318520174469 70.89362399873939,25.84339186864285 70.90155201561971,25.742582091451514 70.88965999029922,25.713400313843497 70.89626667103283,25.708094536096585 70.90551602405988,25.647078092007092 70.90551602405988,25.607284758905248 70.9068373602066,25.548921203689215 70.9134440409402,25.511780759460827 70.92269339396725,25.50912787058737 70.93062141084758,25.448111426497878 70.94647744460823,25.437499871004054 70.95969080607544,25.379136315788017 70.96761882295577,25.355260315926913 70.9636548145156,25.34995453818 70.97422550368938,25.312814093951612 70.97422550368938,25.299549649584332 70.96233347836889,25.04487231773254 70.95440546148856,25.01038476237761 70.97158283139593,24.959979873781943 70.96233347836889,24.957326984908487 70.9755468398361,24.77427765264001 70.99008153745004,24.73979009728508 70.99008153745004,24.69734387530978 70.97158283139593,24.69734387530978 70.99008153745004,24.67081498657522 70.96761882295577,24.625715875726463 70.99008153745004,24.59388120924499 70.97951084827626,24.57265809825734 70.96233347836889,24.543476320649322 70.95440546148856,24.535517654028954 70.97026149524922,21.56693500463149 70.31355743032877,21.564282115758033 70.32412811950255,21.487348338427804 70.30959342188861,21.471431005187068 70.29770139656812,21.415720338844487 70.27391734592713,21.367968339122275 70.26466799290009,21.34409233926117 70.26466799290009,21.296340339538958 70.25673997601976,21.24062967319638 70.23691993381894,21.23532389544947 70.2408839422591,21.21144789558836 70.21049321088452,21.20614211784145 70.22370657235173,21.190224784600712 70.21974256391157,21.1849190068538 70.19992252171075,20.349259011715105 69.93961930080667,20.31742434523363 69.96472468759437,20.285589678752157 69.97661671291486,20.256407901144136 69.97529537676814,20.256407901144136 69.96472468759437,20.203350123675015 69.94094063695339,20.16355679057317 69.9356552923665,20.155598123952803 69.94358330924683,20.129069235218243 69.9356552923665,19.731135904199814 69.80748568613454,19.723177237579446 69.77841629090668,19.67011946011032 69.81541370301487,19.593185682780092 69.80484301384111,19.545433683057883 69.80087900540094,19.502987461082583 69.79691499696078,19.447276794740002 69.78238029934684,19.42870657262581 69.786344307787,19.39421901727088 69.77709495475996,19.322591017687564 69.77841629090668,19.293409240079544 69.7731309463198,19.272186129091896 69.77841629090668,19.195252351761667 69.7612389209993,19.174029240774015 69.74538288723865,19.144847463166 69.74141887879848,19.134235907672174 69.7480255595321,19.097095463443786 69.73349086191816,18.23490657957053 69.4811156578944,18.232253690697075 69.46658096028047,18.189807468721774 69.45997427954687,18.152667024493386 69.46525962413375,18.131443913505738 69.45336759881326,15.627116816963106 68.19017024254778,15.62446392808965 68.17431420878712,15.592629261608174 68.18092088952073,15.515695484277945 68.14920882199942,15.475902151176104 68.15317283043959,15.412232818213155 68.14260214126581,15.391009707225507 68.13071011594532,15.34591059637675 68.1042833930109,15.314075929895278 68.07653533392975,15.298158596654538 68.06464330860926,15.27693548566689 68.0606793001691,15.279588374540346 68.04482326640844,14.900225265636113 67.8862629288019,14.879002154648465 67.87701357577485,14.849820377040444 67.85455086128059,14.828597266052796 67.8611575420142,14.802068377318236 67.84133749981338,14.78349815520404 67.82548146605272,14.77023371083676 67.82944547449289,13.555210606793828 66.94547159233639,13.544599051300004 66.93225823086918,13.536640384679636 66.94018624774951,13.281963052827845 66.73273647271428,13.268698608460564 66.71688043895362,13.25543416409328 66.71291643051346,13.223599497611808 66.67724035455198,13.197070608877247 66.6719550099651,13.165235942395771 66.65742031235116,13.024632832102593 66.52792936997248,12.995451054494577 66.53189337841265,12.971575054633469 66.5226440253856,9.676687073800895 63.844295655981696,9.666075518307071 63.83372496680793,9.663422629433615 63.82315427763416,9.67403418492744 63.81786893304727,9.658116851686703 63.809940916166944,9.634240851825599 63.829760958367764,9.623629296331773 63.81522626075383,9.607711963091035 63.799370226993176,9.607711963091035 63.79144221011285,9.589141740976842 63.787478201672684,9.562612852242282 63.77294350405875,9.244266187427538 63.52321097232844,9.231001743060258 63.51660429159483,9.217737298692978 63.515282955448114,9.201819965452241 63.50339093012762,9.167332410097309 63.482249551780086,9.14610929910966 63.48621356022025,9.02938218867759 63.44657347581861,9.00020041106957 63.447894811965334,8.971018633461552 63.439966795085006,8.93122530035971 63.425432097471074,8.907349300498606 63.38711334921616,8.907349300498606 63.39504136609648,8.90469641162515 63.408254727563694,8.8834733006375 63.40957606371042,8.878167522890585 63.417504080590746,8.848985745282569 63.425432097471074,8.817151078801094 63.42939610591124,8.740217301470866 63.41354007215058,8.732258634850496 63.42146808903091,8.711035523862847 63.417504080590746,8.660630635267179 63.40957606371042,8.647366190899898 63.40164804683009,8.644713302026442 63.3897560215096,7.978838194788942 63.088491380057164,7.968226639295118 63.080563363176836,7.915168861825993 63.04224461492192,7.885987084217976 63.023745908867824,7.718855085190237 62.970892462998975,7.68171464096185 62.96692845455881,7.588863530390883 62.92464569786373,7.583557752643971 62.93653772318422,7.564987530529778 62.92464569786373,7.517235530807566 62.906146991809635,7.485400864326093 62.906146991809635,7.469483531085356 62.89821897492931,7.448260420097706 62.906146991809635,7.456219086718074 62.92068168942357,7.442954642350793 62.93653772318422,7.416425753616232 62.94842974850471,7.413772864742776 62.95503642923832,7.384591087134758 62.95900043767848,7.376632420514389 62.96692845455881,7.331533309665634 62.973535135292416,7.323574643045266 62.98939116905307,7.286434198816879 62.9788204798793,7.278475532196511 62.98939116905307,7.283781309943423 62.99996185822684,7.246640865715037 62.98939116905307,7.236029310221212 62.99996185822684,7.20950042148665 62.993355177493235,7.17501286613172 62.993355177493235,7.151136866270614 62.9973191859334,7.151136866270614 62.98542716061291,7.100731977674947 62.961643109971924,7.090120422181122 62.95900043767848,7.060938644573104 62.970892462998975,7.021145311471262 62.95239375694487,6.922988423153383 62.91407500868996,6.9070710899126455 62.90218298336947,6.89645953441882 62.9101110002498,5.225139544141428 62.20848150634083,5.209222210900691 62.205838834047384,5.180040433292673 62.21376685092771,5.177387544419217 62.1939468087269,5.14024710019083 62.2005534894605,5.097800878215532 62.1939468087269,5.095147989342076 62.18337611955313,5.095147989342076 62.16619874964575,5.103106655962444 62.14902137973837,5.113718211456269 62.12655866524412,5.116371100329725 62.10013194230969,4.991685323277284 61.7394071742548,4.983726656656916 61.72883648508103,4.98107376778346 61.72487247664087,4.970462212289635 61.71298045132038,4.970462212289635 61.68258971994579,4.970462212289635 61.6706976946253,4.989032434403828 61.625772265636776,4.9943382121507405 61.59802420655563,4.9969911010241965 61.580846836648256,4.973115101163091 61.41700115445482,4.9943382121507405 61.40510912913433,4.98107376778346 61.2848675397827,4.98107376778346 61.26108348914172,4.9943382121507405 61.25051279996795,5.007602656518022 61.24258478308762,5.007602656518022 61.224086077033526,5.010255545391478 61.22012206859336,4.949239101301986 60.807865190816344,4.965156434542723 60.79597316549585,5.227792433014884 59.51691977546972,5.222486655267972 59.50106374170906,5.227792433014884 59.468030338041025)

The shapes are broadly the same:

But if you zoom in you can see some real differences:

[urschrei]

Does testbuilder have a concave hull function?

[michaelkirk]

Git bisect tells me this is the commit that introduced the failure:

georust/rstar@84d1265

I'm not trying to imply there's anything wrong with that commit - it could just as likely have surfaced an existing bug in geo (or at least in our test).

[michaelkirk]

Does testbuilder have a concave hull function?

My understanding is that concave hull does not have a rigorous definition, so comparing to an existing implementation would be directionally helpful, but not useful for a unit test like this, unless our implementation was based on JTS's (which it was not AFAIK).

[michaelkirk]

BTW if you don't have JTS test builder, you should download it now. I use it all the time!

You can download from their GH release page: https://github.com/locationtech/jts/releases/tag/1.20.0

Launch with java -jar JTSTestBuilder.jar

[urschrei]

Hm that concave hull function has always been kinda troublesome, including in the very recent past.

[urschrei]

BTW if you don't have JTS test builder, you should download it now. I use it all the time!

You can download from their GH release page: https://github.com/locationtech/jts/releases/tag/1.20.0

Launch with java -jar JTSTestBuilder.jar

Oh I do just not at the big screen rn (but yes everyone should have it!)

[michaelkirk]

I think the root cause is a bug in rstar - see georust/rstar#181

[michaelkirk]

Fixed in rstar, released yesterday.