Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

schema_plugins divergence #10

Open
pmauduit opened this issue Dec 22, 2020 · 3 comments
Open

schema_plugins divergence #10

pmauduit opened this issue Dec 22, 2020 · 3 comments
Assignees

Comments

@pmauduit
Copy link
Member

Even with the PR #9 being merged, we still have a lot of divergences between this repository and https://github.com/georchestra/geonetwork/tree/georchestra-gn3.8.2/schemas (ending in the webapp into WEB-INF/data/config/schema_plugins/).

I would be in favor of leaving the config/schema_plugins empty and leave GN copy the file at first startup. Maintaining customizations in both repositories does not make sense to me.

@landryb following this comment #7 (comment), is that ok for you if we leave GN creating the schemas at first bootstrap of the webapp, so that the user can customize it afterwards ?

@landryb
Copy link
Member

landryb commented Dec 23, 2020

if the problem fixed by 6a47646 doesnt happen with what's shipped then i have no objection :)

@fvanderbiest
Copy link
Member

I would be in favor of leaving the config/schema_plugins empty and leave GN copy the file at first startup.

👍

@pmauduit
Copy link
Member Author

if the problem fixed by 6a47646 doesnt happen with what's shipped then i have no objection :)

I have not planned to touch the thesauri, only the schema dir.

pmauduit added a commit that referenced this issue Dec 24, 2020
Instead, leave GN copy them from the webapp during its first bootstrap.
See #10 for the motivation.

Tests: tested with the docker compo, with an extra volume pointing to
the schemadir (instead of using the default one pointing directly into
the webapp). OK: the schemas are created there at first bootstrap.
@fvanderbiest fvanderbiest self-assigned this Jan 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants