Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ogc-features service - sample-data profile to be kept ? #26

Open
pmauduit opened this issue May 6, 2024 · 1 comment
Open

ogc-features service - sample-data profile to be kept ? #26

pmauduit opened this issue May 6, 2024 · 1 comment
Labels
question Further information is requested

Comments

@pmauduit
Copy link
Member

pmauduit commented May 6, 2024

We still have a sample-data profile defined in the main (e.g. not "test") codebase:
https://github.com/georchestra/data-api/blob/main/src/services/ogc-features/src/main/java/com/camptocamp/opendata/ogc/features/autoconfigure/geotools/SampleDataBackendAutoConfiguration.java

I wonder if this is still useful or if we could consider that the data-api should only work against a postgresql/postgis backend ? For now, the profile is still being used in the https://github.com/georchestra/data-api/blob/main/src/services/ogc-features/src/test/java/com/camptocamp/opendata/ogc/features/server/impl/DataApiImplTest.java class, but maybe we could share the code between this one and the CollectionsApiImplPostgisTest class, so that both share the same postgis backend instead ?

@pmauduit pmauduit added the question Further information is requested label May 6, 2024
@pmauduit pmauduit changed the title sample-data profile to be kept ? ogc-features service - sample-data profile to be kept ? May 6, 2024
@pmauduit
Copy link
Member Author

pmauduit commented May 6, 2024

It looks like the sample-data profile is still referenced in the README.md:
https://github.com/georchestra/data-api/blob/main/src/services/ogc-features/README.md#development

So maybe the profile should be kept, but we could still refactor the testsuite so that it makes use of a postgis container instead of using the sample data provided ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

1 participant