Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update SvelteKit preset #93

Open
geoffrich opened this issue Oct 29, 2022 · 4 comments
Open

Update SvelteKit preset #93

geoffrich opened this issue Oct 29, 2022 · 4 comments
Milestone

Comments

@geoffrich
Copy link
Owner

With the work in #92 the amount of setup needed to deploy SvelteKit to Azure SWA is very minimal. We should make sure the SvelteKit preset in the Azure SWA CLI reflects these defaults to make deployment as painless as possible.

I don't think any work will need to happen in this repo (maybe docs?). Mainly creating this as a reminder to myself.

@geoffrich
Copy link
Owner Author

geoffrich commented Jan 23, 2023

It would also be nice to get SvelteKit as an option on the "create Static Web App" flow via the VS Code extension, but not sure what controls that.

image

Edit: opened Azure/static-web-apps#1057

@geoffrich
Copy link
Owner Author

v0.12 of the extension should support SvelteKit now. Still want to verify.

@geoffrich
Copy link
Owner Author

Also might be good to update the README to note that the extension will set this up for you.

@geoffrich geoffrich added this to the 1.0 milestone Aug 20, 2023
@geoffrich
Copy link
Owner Author

geoffrich commented Aug 20, 2023

Anecdotally, when I ran through this setup as part of another issue investigation it didn't set the right values for api_location in the workflow (it set it to .svelte-kit/azure-tmp/api instead of build/server). Need to investigate further.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant