Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update code style in dynamic core 2 #6187

Merged
merged 1 commit into from
Dec 13, 2024

Conversation

gassmoeller
Copy link
Member

Follow up to #6177, this PR does the following:

  • Address the comments in Update code style in dynamic core plugin #6177 (the variable n that was a double before was meant to be and also treated like an unsigned int, I checked the original reference)
  • Reorder functions in our usual structure (constructor -> initialize/update -> everything else -> declare_parameters -> parse_parameters)
  • Added lots of spaces around equal signs and some operators to improve readability

I think I will make at least one additional follow-up, but I will separate the PRs, because this PR should be purely code structure changes while the next one may actually affect results

@gassmoeller gassmoeller force-pushed the update_dynamic_core_2 branch 2 times, most recently from 3816e82 to 3dfac45 Compare December 11, 2024 14:31
@gassmoeller gassmoeller force-pushed the update_dynamic_core_2 branch from 3dfac45 to 7d5bac3 Compare December 12, 2024 15:33
@gassmoeller
Copy link
Member Author

I guess this shows the dangers of relying on (or forgetting about) automatic type conversions. I fixed the accidental integer conversion in fun_Sn, test results should now be fine.

@tjhei tjhei merged commit 019cb2b into geodynamics:main Dec 13, 2024
8 checks passed
@gassmoeller gassmoeller deleted the update_dynamic_core_2 branch December 13, 2024 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants