PB-755: Spec for collection assets #455
Conversation
benschs
force-pushed
the
feat-PB-755-spec-col-assets
branch
from
2cd049b
to
a6bfdf6
Compare
There was a problem hiding this comment.
Hi @benschs,
As discussed, I have had a look and found mostly typos or unclear writing.
The only more important remarks are
- Should we mention the parallel upload capabilities?
- Is the response "500" intentional or should it be "5XX"?
Note to myself: openapitransactional.yaml is generated from the other files (responses.yaml, paths.yaml, tags.yaml).
| description: | | ||
| Collection Asset files are uploaded via the STAC API using the API requests described in this chapter. | ||
|
|
||
| The flow of the requests is the same as for assets that belong to features, which is described under [Asset Upload Management](#tag/Asset-Upload-Management) |
There was a problem hiding this comment.
Nothing to do with your PR per se, but I noticed that we tend to use item and feature interchangeably. I found it a bit confusing at first, but maybe there's a good reason? Or maybe there would be value in unifying it?
There was a problem hiding this comment.
I am not sure on the difference, it seems that feature comes from OGC, but STAC uses items. I use them more or less interchangeably.
Add CRUD endpoints for collection level assets. Add endpoints for collection asset upload management. As process for upload is the same as for feature assets, only link to description.
benschs
force-pushed
the
feat-PB-755-spec-col-assets
branch
from
a6bfdf6
to
311cb5f
Compare
Thanks for all the feedback, I think I fixed most of the typos. I added a short sentence about parallel capabilities in the tag description for the multipart upload process. |
Had another look. Most are fixed, some still open. Would you mind having another look please? 😇 |
Add CRUD endpoints for collection level assets.
Add endpoints for collection asset upload management. As process for upload is the same as for feature assets, only link to description.