Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PB-470: icons are not centered #79

Merged
merged 3 commits into from
May 3, 2024
Merged

PB-470: icons are not centered #79

merged 3 commits into from
May 3, 2024

Conversation

LukasJoss
Copy link
Contributor

No description provided.

rebert
rebert approved these changes May 3, 2024
View reviewed changes
Copy link
Contributor

@rebert rebert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as the scripts are a one shot lgtm. thanks for your work

@rebert
Copy link
Contributor

rebert commented May 3, 2024 •
edited
Loading

I would either or:

  • remove the scripts from the pr
  • adapt towards format and linting and make a comment about the context why the scripts are there and how to use them

@LukasJoss LukasJoss force-pushed the feat-PB-470-icons-are-not-centered branch from ae03906 to 94015c3 Compare May 3, 2024 09:34
@LukasJoss
Copy link
Contributor Author

The files are slightly large since due to the shifting some metadata was added but it should not make much of an impact

@LukasJoss
Copy link
Contributor Author

LukasJoss commented May 3, 2024 •
edited
Loading

I would either or:

* remove the scripts from the pr

* adapt towards format and linting and make a comment about the context why the scripts are there and how to use them

I probably keep the shift script (in case wee need to shift it back or something) but remove the other

@LukasJoss LukasJoss requested a review from pakb May 3, 2024 09:46
@LukasJoss LukasJoss merged commit e63a6b0 into develop May 3, 2024
3 checks passed
@LukasJoss LukasJoss deleted the feat-PB-470-icons-are-not-centered branch May 3, 2024 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rebert rebert rebert approved these changes

@pakb pakb Awaiting requested review from pakb

Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LukasJoss @rebert