PB-91: Added script to Makefile to convert svg images to pngs #75
Conversation
rebert
force-pushed
the
feat-PB-91-create-png
branch
2 times, most recently
from
bc763f1
to
8cebbc8
Compare
|
for testing: |
| global opts # pylint: disable=global-variable-undefined | ||
| opts = validate_args(sys.argv) | ||
| svg2png() |
There was a problem hiding this comment.
instead of using the global pass the opts to svg2png() function.
Makefile
Outdated
| @echo -e " \033[1mMaintenance TARGETS\033[0m " | ||
| @echo "- svg2png Convert svg images to pngs SVG_DIR= ($(SVG_DIR)) SYMBOL_CATH= (f.ex. babs2) ($(SYMBOL_CATH))" |
There was a problem hiding this comment.
I don't see the plus value to have this make target, the direct usage of the python is probably much easier. I personnaly would remove this target and add a short readme in the README.md file about this tool and how to use it.
There was a problem hiding this comment.
Thanks a lot, also for deploying and testing!
You documented a problem with nor quadratic icons in the ticket comments: https://jira.swisstopo.ch/browse/PB-63
Is there only one non-quadratic icon per set?
If so, IMHO it would be easier if we ask BABS to adapt the single icon, than for us adapting the service.
As far as I know, we only have quadratic icons so far. Non quadratic icons could mess up the nice layout of the dropdown menu for selecting the icons, I guess.
What's your take on this @rebert @boecklic @pakb @ltshb --> Probably better to document this discussion in the ticket comments, rather than here: https://jira.swisstopo.ch/browse/PB-63
rebert
force-pushed
the
feat-PB-91-create-png
branch
from
8cebbc8
to
386ccd8
Compare
No description provided.