change Ping to check for Docker header #199
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change Registry.Ping() to:
- respect http 401 response code as valid
- conform to the Specs by requiring header
Docker-Distribution-API-Version
Change the TokenTransport unit tests to emit that header.
Remove the naive workaround inside Registry.Pingable() as
iterating over all sites that do not support the old
ping would require huge and constant effort. (Not only GCR.)
I add separate Registry.PingClient, because the Client handles 401
by closing the body so it disables the possibility of disinguishing
whether the 401 contained Docker-Distribution-API-Version header.
Refactor: simplify current TestPingable
Signed-off-by: Jakub Bielecki <[email protected]>
ghost
reviewed
Nov 20, 2019
There was a problem hiding this comment.
Found some fixes!
P.S. share your ideas, feedbacks or issues with us at https://github.com/fixmie/feedback (this message will be removed after the beta stage).
|
This has been merged into https://github.com/ttys3/reg fork which I now regard as the maintained source-of-truth for my future work with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Registry.Ping() to:
Docker-Distribution-API-Version
Change the TokenTransport unit tests to emit that header.
Remove the naive workaround inside Registry.Pingable() as
iterating over all sites that do not support the old
ping would require huge and constant effort. (Not only GCR.)
I add separate Registry.PingClient, because the Client handles 401
by closing the body so it disables the possibility of disinguishing
whether the 401 contained Docker-Distribution-API-Version header.
Refactor: simplify current TestPingable
Closes #198