-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inconsistency API response #179
Comments
I'll look into it! 👍 |
These API responses are made for clarity, for example "Not affiliated to any Nation" is still information about the character returning a null-able value here could mean that the affiliation is not known or hasn't been added yet or that there is none so the current output provides more clarity. |
I think it's better to make a new key-value for example But it will make a breaking changes for the stucture. |
hello, I am debanjan mukherjee ,I would like to change the api and can make it more responsive .I have some projects on that .If you assign me I can do that. |
When you request to
/characters/amber
, the response containswhich in the other request it doesn't exists.
And in some endpoints e.g.
/characters/keqing
or/characters/jean
the response containwhich in the other request isn't present.
And other things like:
nation
key in/characters/aloy
has'Unknown'
string valuebirthday
key in/characters/traveler
(s) is missingaffilation
key in/characters/traveler
(s) has'Not affilated to any Nation'
string valueIs it better that if the missing key should be nullable instead of undefined or having an empty string?
The text was updated successfully, but these errors were encountered: