Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pathways widget and GO-CAM landing to AmiGO pages #66

Closed
4 tasks done
kltm opened this issue Mar 3, 2023 · 19 comments
Closed
4 tasks done

Add pathways widget and GO-CAM landing to AmiGO pages #66

kltm opened this issue Mar 3, 2023 · 19 comments
Assignees
Labels

Comments

@kltm
Copy link
Member

kltm commented Mar 3, 2023

Project link

https://github.com/orgs/geneontology/projects/129

Project description

This project is to scoped to

This is a follow-up to Patrick's previous work here: geneontology/amigo#650

We will work with the POs to make the (minimal) changes to AmiGO necessary to support this (this is not meant to be a major push in AmiGO) using current technology and stack.

PI

Chris

Product owner (PO)

Seth

Technical lead (TL)

Seth

Other personnel (OP)

Patrick, Seth (, Tremayne)

Technical specs

N/A
All remaining work is an extension of what we currently have and review is not necessary at this time.

Other comments

Noting previous geneontology/amigo#237

@kltm kltm added Needs LA approval Needs final approval from the Lead Architect Needs PI Needs PM approval Needs final approval from the Project Manager Needs PO Needs tech doc Needs TL labels Mar 3, 2023
@kltm kltm moved this from Hopper to Priority (project triage) in Project Metadata Overview Mar 9, 2023
@pgaudet pgaudet removed Needs LA approval Needs final approval from the Lead Architect Needs PM approval Needs final approval from the Project Manager labels Mar 9, 2023
@kltm kltm moved this from Priority (project triage) to Resourcing (assign PI, PO, TL, staff) in Project Metadata Overview Mar 10, 2023
@kltm kltm moved this from Resourcing (assign PI, PO, TL, staff) to Creation (initial requirements document) in Project Metadata Overview Mar 10, 2023
@kltm kltm moved this from Creation (initial requirements document) to Resourcing (assign PI, PO, TL, staff) in Project Metadata Overview Mar 10, 2023
@kltm
Copy link
Member Author

kltm commented Mar 15, 2023

@kltm Bump start this; contact Patrick

@kltm kltm moved this from Resourcing (assign PI, PO, TL, staff) to Creation (initial requirements document) in Project Metadata Overview Mar 17, 2023
@kltm kltm added Needs LA approval Needs final approval from the Lead Architect Needs PM approval Needs final approval from the Project Manager and removed Needs PI Needs PO Needs TL labels Mar 17, 2023
@kltm kltm moved this from Creation (initial requirements document) to Requirement cycle (Planning/Technical) in Project Metadata Overview Mar 24, 2023
@kltm kltm moved this from Requirement cycle (Planning/Technical) to Active in Project Metadata Overview Mar 24, 2023
@pgaudet
Copy link

pgaudet commented Apr 19, 2023

Some test version can be presented at the GOC meeting

@pgaudet pgaudet removed the Needs PM approval Needs final approval from the Project Manager label Apr 19, 2023
@kltm
Copy link
Member Author

kltm commented Apr 21, 2023

@vanaukenk @ukemi , @pkalita-lbl has made some very nice progress, which is now visible at: https://amigo-staging.geneontology.io .
@cmungall Has also suggested adding the tab to term pages, which I've added to "Discussion". I think we're at the point where we (you all at least) should meet and figure out next steps.

@vanaukenk
Copy link

vanaukenk commented Apr 21, 2023

Neato! Thanks @kltm and @pkalita-lbl
I just checked my favorite gene, pmk-1, which has two models.
At a quick glance, they look good, but it looks like we're using the older pathway preview rather than Tremayne's updated version?

@pkalita-lbl
Copy link

That's right, it is using a slightly older version of the widget. The latest version(s) have technical dependencies that make it incompatible with AmiGO. It's possible we could work around it in AmiGO, but it might be less effort to rework those dependencies in the widget for a future version.

@ukemi
Copy link

ukemi commented Apr 21, 2023

I just searched on one of my favorite genes Pkm Mus musculus (MGI:MGI:97591). It should at least bring back gomodel:5745387b00001516, but returns zero models.

@pkalita-lbl
Copy link

Yeah, another big caveat is that anything with an MGI ID won't work right now. The new API that backs this needs a fix so that it can resolve MGI:MGI:xxxxx identifiers (in addition to MGI:xxxxx as it currently expects).

@pkalita-lbl
Copy link

@ukemi The MGI: prefix has been worked out in the new API and the Pkm models should be showing up now.

@ukemi
Copy link

ukemi commented Apr 21, 2023

Beautiful! For now I also see the gene-centric models, but at some point we should not display those. A first step might be to use the same filtering criteria that is used other places to assign 'causal model' status. It's not ideal, but a good first step.

@pkalita-lbl
Copy link

Chris also pointed that out. I've already made the change, but it's not deployed on amigo-staging yet.

@pgaudet pgaudet assigned vanaukenk and ukemi and unassigned pgaudet Apr 30, 2023
@kltm kltm changed the title Add pathways widget to AmiGO pages Add pathways widget and GO-CAM landing to AmiGO pages May 23, 2023
@kltm
Copy link
Member Author

kltm commented May 24, 2023

Talking with @pkalita-lbl yesterday, I believe that no tech doc is needed for the remaining parts of this project.

@kltm kltm added Ready and removed Needs LA approval Needs final approval from the Lead Architect Needs tech doc labels May 24, 2023
@pgaudet
Copy link

pgaudet commented May 31, 2023

  • Implementation of the Pathway viewer in term pages will be split in a different project
  • @ukemi and @vanaukenk will spec out (soon) which metadata will be shown in the models pages for the current project - which we can get to from the gene product pages

@kltm
Copy link
Member Author

kltm commented May 31, 2023

Rescoped; now also see #78

@kltm
Copy link
Member Author

kltm commented Aug 1, 2023

Getting this out live will need to wait on the merged GO API hitting production: #14

@tmushayahama
Copy link

Just to note, when LP left I was told to create a GOCAM browser landing page as a web component and it was in working but got abandoned https://github.com/geneontology/wc-web-gocam

Tagging @kltm @pkalita-lbl

@pgaudet
Copy link

pgaudet commented Sep 25, 2023

Hi Pascale,

David and I can do this, but we will need input from Seth (cc'ed here) and perhaps other GO software people.

On two previous manager's calls (8/30 and 9/13), we noted that finishing the pathways widget project was dependent on some of the API refactor work.

Seth, let us know if you have time before Wednesday to touch base about this. Next Monday or Tuesday would work for me; tomorrow is mostly booked.

Thanks,
--Kimberly

@kltm
Copy link
Member Author

kltm commented Sep 25, 2023

[Bringing in email thread]


[@pgaudet] As mentioned, as far as I'm concerned, this project has no active parts that can proceed without the production deployment of the new GO API. There is no more work here for anybody but myself and Sierra; the remaining work is probably on the order of half an hour.

While the new GO API--which is required for any further action--is /technically/ deployed, it has some data issues and may need to be withdrawn (geneontology/go-fastapi#77; GO API project currently, but may more to general bug later today) until Sierra can take a look at it. For this reason, we have not proceeded with updating everything to point at the new pages, etc.

As there is no more functional action from Kimberly and David here, it may make the communication loop shorter and more clear if I'm put on as PO, as there are only technical considerations remaining (delta the documentation ticket for you and Suzi geneontology/go-site#1929).


As an update to the email thread, it looks like we have the GO API fix in that we wanted, so I'll try wrapping up this project in the next day or so.

@pgaudet pgaudet assigned kltm and unassigned vanaukenk and ukemi Sep 26, 2023
@pgaudet
Copy link

pgaudet commented Sep 26, 2023

Hi @kltm I changed the PO and assignee to reflect your comment above.

@kltm kltm moved this from Active to Complete in Project Metadata Overview Sep 26, 2023
@kltm
Copy link
Member Author

kltm commented Sep 26, 2023

@pgaudet No more active tickets here; closing out.

@kltm kltm closed this as completed Sep 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Complete - 2023 and earlier
Development

No branches or pull requests

6 participants