fix(description): do not crash on description open #533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
KuznetsovRoman
approved these changes
Feb 27, 2024
Comment on lines
+28
to
+34
| const detailsContent = component.find('.details__content'); | ||
|
|
||
| assert.isTrue(detailsContent.contains(<h3>simple text</h3>)); |
There was a problem hiding this comment.
Почему в трех тестах выше component.find прямо внутри ассерта, а тут - нет?
DudaGod
approved these changes
Feb 27, 2024
| @@ -0,0 +1,32 @@ | |||
| import React from 'react'; | |||
There was a problem hiding this comment.
Странно, что на него тестов не было
| @@ -0,0 +1,32 @@ | |||
| import React from 'react'; | |||
| import {mkConnectedComponent} from '../../utils'; | |||
| import Description from 'lib/static/components/section/body/description'; | |||
There was a problem hiding this comment.
Я бы сначала импортил внешние зависимости, затем внутренние по полному пути, а в конце хелперы для тестов по относительному.
sipayRT
force-pushed
the
sp.INFRADUTY-26511.description
branch
from
70d6e99 to
9b0bb06
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.