Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: re-write the rest of the GUI logic to typescript #520

Merged
merged 9 commits into from
Nov 20, 2023
Merged

feat: re-write the rest of the GUI logic to typescript #520

merged 9 commits into from
Nov 20, 2023

Conversation

shadowusr
Copy link
Member

@shadowusr shadowusr commented Nov 8, 2023 •
edited
Loading

What's done?

  • Re-wrote tool-runner and related files to typescript.

⚠️ Would be more convenient to view individual commits to see difference between files correctly.

@shadowusr shadowusr changed the title Users/shadowusr/hermione 1004.typescript 2 feat: re-write the rest of the GUI logic to typescript Nov 8, 2023
@shadowusr shadowusr force-pushed the users/shadowusr/HERMIONE-1004.typescript-2 branch from 0d4d4f0 to 56fb25e Compare November 13, 2023 22:27
@shadowusr shadowusr force-pushed the users/shadowusr/HERMIONE-1004.typescript-2 branch from 56fb25e to 80602eb Compare November 13, 2023 22:33
@shadowusr shadowusr requested a review from DudaGod November 13, 2023 22:35
@shadowusr shadowusr marked this pull request as ready for review November 13, 2023 22:35
sipayRT
sipayRT approved these changes Nov 14, 2023
View reviewed changes
Copy link
Member

@sipayRT sipayRT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

в остальном ок

lib/gui/tool-runner/index.ts Outdated Show resolved Hide resolved
DudaGod
DudaGod approved these changes Nov 14, 2023
View reviewed changes
Copy link
Member

@DudaGod DudaGod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok

lib/gui/app.js Show resolved Hide resolved
lib/gui/tool-runner/index.ts Outdated Show resolved Hide resolved
lib/gui/tool-runner/index.ts Show resolved Hide resolved
package.json Show resolved Hide resolved
@shadowusr shadowusr merged commit 6d0a7b3 into master Nov 20, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sipayRT sipayRT sipayRT approved these changes

@DudaGod DudaGod DudaGod approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shadowusr @sipayRT @DudaGod