Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: get rid of chrome-pwt and add e2e tests for tinder #517

Merged
merged 4 commits into from
Oct 30, 2023
Merged

test: get rid of chrome-pwt and add e2e tests for tinder #517

merged 4 commits into from
Oct 30, 2023

Conversation

shadowusr
Copy link
Member

What's done:

  • got rid of fake chrome-pwt browser that was previously used to have different screenshots for reports generate by hermione and playwright. After flaky screenshots were fixed, the need in this disappeared
  • added e2e tests for tinder screenshot accepting mode

KuznetsovRoman
KuznetsovRoman approved these changes Oct 26, 2023
View reviewed changes
Copy link
Member

@KuznetsovRoman KuznetsovRoman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Если не получится через await browser.executeAsync(done => setTimeout(done, 0)); подождать следующего такта event loop, то и ладно.

Еще непонятно, почему в test-details.hermione.js раньше искали mesage, а теперь stack

В остальном /ok

sipayRT
sipayRT approved these changes Oct 26, 2023
View reviewed changes
test/func/tests/common-tinder/index.hermione.js Show resolved Hide resolved
test/func/tests/local.hermione.conf.js Show resolved Hide resolved
test/func/tests/common-tinder/index.hermione.js Show resolved Hide resolved
test/func/tests/common-tinder/index.hermione.js Show resolved Hide resolved
test/func/tests/local.hermione.conf.js Outdated Show resolved Hide resolved
@shadowusr shadowusr merged commit 512fb03 into master Oct 30, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KuznetsovRoman KuznetsovRoman KuznetsovRoman approved these changes

@sipayRT sipayRT sipayRT approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shadowusr @sipayRT @KuznetsovRoman