Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Would like to be able to set mount options #40

Open
iay opened this issue Apr 21, 2024 · 4 comments
Open

Would like to be able to set mount options #40

iay opened this issue Apr 21, 2024 · 4 comments
Labels

Comments

@iay
Copy link

iay commented Apr 21, 2024

The mount line in /etc/fstab is hard-wired to have options set to "sw". It would be nice to be able to override this default, for example to set a discard policy.

Let me know if you'd be interested in a PR for this one.

@colin-nolan
Copy link

I also thought the same thing - #12. I ended up using a fork.

@khawarizmus
Copy link

@colin-nolan was it your fork? is this role no longer maintained?

@colin-nolan
Copy link

was it your fork?

Yes - here's what I'm currently using in my Galaxy requirements yml:

  # Forked from upstream with PRs that will never be merged:
  #   - https://github.com/geerlingguy/ansible-role-swap/pull/11
  #   - https://github.com/geerlingguy/ansible-role-swap/pull/12
  - name: geerlingguy.swap
    src: https://github.com/colin-nolan/ansible-role-swap.git
    version: 82f2466905b3d01fe9ab825534370c4730fa9590

is this role no longer maintained?

I can't comment on this role's maintainence status but I can direct you towards this (admittedly, rather old) post by Jeff: https://www.jeffgeerling.com/blog/2016/why-i-close-prs-oss-project-maintainer-notes.

I see a lot of PRs for one-off functionality that I've personally never seen in the wild. Sure there are unicorn systems out there that need to configure hairy details in some obscure app... but I'm not going to include code for that in my projects because (a) I don't use it, so I can't vouch for it, and (b) it adds maintenance overhead—even if it's a 'simple' addition. If you are one of the unicorns, please fork my work. I won't get offended!

Copy link

github-actions bot commented Nov 1, 2024

This issue has been marked 'stale' due to lack of recent activity. If there is no further activity, the issue will be closed in another 30 days. Thank you for your contribution!

Please read this blog post to see the reasons why I mark issues as stale.

@github-actions github-actions bot added the stale label Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants