Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ethexe): allocation failure on huge journal returned from runtime #4397

Merged
merged 1 commit into from
Dec 12, 2024
Merged

fix(ethexe): allocation failure on huge journal returned from runtime #4397

merged 1 commit into from
Dec 12, 2024

Conversation

breathx
Copy link
Member

@breathx breathx commented Dec 12, 2024

No description provided.

@breathx breathx added the A0-pleasereview PR is ready to be reviewed by the team label Dec 12, 2024
grishasobol
grishasobol reviewed Dec 12, 2024
View reviewed changes
Copy link
Member

@grishasobol grishasobol left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be great if you add test or TODO to make test for big memory

ethexe/runtime/src/wasm/api/mod.rs Show resolved Hide resolved
@breathx breathx merged commit 0e966fa into master Dec 12, 2024
19 checks passed
@breathx breathx deleted the dn-fix-big-journal branch December 12, 2024 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grishasobol grishasobol grishasobol approved these changes

Assignees
No one assigned
Labels
A0-pleasereview PR is ready to be reviewed by the team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@breathx @grishasobol