From afab1bb31a9cd4f79f36822d6b7c07a2adcd89bf Mon Sep 17 00:00:00 2001 From: Adam Alexander <50453312+a-alexander@users.noreply.github.com> Date: Tue, 19 Jul 2022 14:49:47 +0100 Subject: [PATCH 1/3] Update solid.ts added extrusionDepth param to solids. --- src/entities/solid.ts | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/entities/solid.ts b/src/entities/solid.ts index b76e182..87a93bd 100644 --- a/src/entities/solid.ts +++ b/src/entities/solid.ts @@ -28,6 +28,9 @@ export default class Solid implements IGeometry { case 13: entity.points[3] = helpers.parsePoint(scanner); break; + case 39: + entity.extrusionDepth = curr.value; + break; case 210: entity.extrusionDirection = helpers.parsePoint(scanner); break; From 259a62a6ff5ec2073713ac09aafcfc357e516eeb Mon Sep 17 00:00:00 2001 From: Adam Alexander <50453312+a-alexander@users.noreply.github.com> Date: Tue, 19 Jul 2022 15:01:23 +0100 Subject: [PATCH 2/3] Update solid.ts Missed type declaration on the interface. --- src/entities/solid.ts | 1 + 1 file changed, 1 insertion(+) diff --git a/src/entities/solid.ts b/src/entities/solid.ts index 87a93bd..da652d5 100644 --- a/src/entities/solid.ts +++ b/src/entities/solid.ts @@ -5,6 +5,7 @@ import IGeometry, { IEntity, IPoint } from './geomtry.js'; export interface ISolidEntity extends IEntity { points: IPoint[]; extrusionDirection: IPoint; + extrusionDepth: number; } export default class Solid implements IGeometry { From a6bab81eb46a212a741c0787ea129e97f4498911 Mon Sep 17 00:00:00 2001 From: Adam Alexander <50453312+a-alexander@users.noreply.github.com> Date: Tue, 19 Jul 2022 15:06:11 +0100 Subject: [PATCH 3/3] Update solid.ts Autodesk call the actual variable i've added 'Thickness' so following suit.. --- src/entities/solid.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/entities/solid.ts b/src/entities/solid.ts index da652d5..63fd089 100644 --- a/src/entities/solid.ts +++ b/src/entities/solid.ts @@ -5,7 +5,7 @@ import IGeometry, { IEntity, IPoint } from './geomtry.js'; export interface ISolidEntity extends IEntity { points: IPoint[]; extrusionDirection: IPoint; - extrusionDepth: number; + extrusionThickness: number; } export default class Solid implements IGeometry { @@ -30,7 +30,7 @@ export default class Solid implements IGeometry { entity.points[3] = helpers.parsePoint(scanner); break; case 39: - entity.extrusionDepth = curr.value; + entity.extrusionThickness = curr.value; break; case 210: entity.extrusionDirection = helpers.parsePoint(scanner);