diff --git a/bin/config_migration/create_config_migration.py b/bin/config_migration/create_config_migration.py index 2d6fff11..0b41cf57 100755 --- a/bin/config_migration/create_config_migration.py +++ b/bin/config_migration/create_config_migration.py @@ -97,7 +97,26 @@ def download_release(release_name, stack_name): try: with tarfile.open(downloaded_file) as tar: tar = tarfile.open(downloaded_file) - tar.extractall(extracted_files) + def is_within_directory(directory, target): + + abs_directory = os.path.abspath(directory) + abs_target = os.path.abspath(target) + + prefix = os.path.commonprefix([abs_directory, abs_target]) + + return prefix == abs_directory + + def safe_extract(tar, path=".", members=None, *, numeric_owner=False): + + for member in tar.getmembers(): + member_path = os.path.join(path, member.name) + if not is_within_directory(path, member_path): + raise Exception("Attempted Path Traversal in Tar File") + + tar.extractall(path, members, numeric_owner=numeric_owner) + + + safe_extract(tar, extracted_files) except: log_error("Opening file {0}{1}{2}, the file may be corrupt." .format(Colours.BLUE, downloaded_file, Colours.NC))