Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Login tests need to be refactored to not use act #359

Open
1 task
gbowne1 opened this issue Feb 22, 2024 · 1 comment
Open
1 task

[Bug]: Login tests need to be refactored to not use act #359

gbowne1 opened this issue Feb 22, 2024 · 1 comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed high-priority medium-complexity This issue is medium complexity need-review Needs review needs-testing This needs testing refactor This needs refactoring testing This is a issue or PR related to testing

Comments

@gbowne1
Copy link
Owner

gbowne1 commented Feb 22, 2024

Describe the Bug

Many of the tests don't pass in /Login/tests/ because they use act

Refactor the test for Login

in particular, refactor login-validation-test.js

Steps to Reproduce

running npm test inside the client

Test Suites: 2 skipped, 4 passed, 4 of 6 total
Tests:       7 skipped, 23 passed, 30 total
Snapshots:   0 total
Time:        35.991 s
Ran all test suites related to changed files.

Watch Usage
 › Press a to run all tests.
 › Press f to run only failed tests.
 › Press q to quit watch mode.
 › Press p to filter by a filename regex pattern.
 › Press t to filter by a test name regex pattern.
 › Press Enter to trigger a test run.

latest run

Screenshots

No response

Which device are you using?

Linux VM

Which operating system are you using?

Lin

Which browser are you using?

Firefox

Additional Context

No response

Contribute

  • I am willing to contribute and submit a pull request
@gbowne1 gbowne1 added help wanted Extra attention is needed good first issue Good for newcomers testing This is a issue or PR related to testing high-priority needs-testing This needs testing medium-complexity This issue is medium complexity refactor This needs refactoring need-review Needs review labels Feb 22, 2024
@gbowne1 gbowne1 added this to the Testing & Deployment milestone Feb 22, 2024
@gbowne1 gbowne1 moved this to Todo in ReactSocialNetwork Feb 22, 2024
@gbowne1
Copy link
Owner Author

gbowne1 commented Feb 23, 2024

@Sky-De @jarmentor

Please feel free to help reduce the number of issues in this project of mine and also in
https://github.com/gbowne1/codebooker

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed high-priority medium-complexity This issue is medium complexity need-review Needs review needs-testing This needs testing refactor This needs refactoring testing This is a issue or PR related to testing
Projects
Development

No branches or pull requests

1 participant