Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CSS] [A11y] Improve Keyboard accessibility #109

Open
gbowne1 opened this issue Feb 27, 2023 · 6 comments
Open

[CSS] [A11y] Improve Keyboard accessibility #109

gbowne1 opened this issue Feb 27, 2023 · 6 comments
Labels
a11y Issues with accessibity css Issues with css design enhancement New feature or request frontend This is a frontend issue or PR good first issue Good for newcomers help wanted Extra attention is needed medium-complexity This issue is medium complexity medium-priority tech-debt This needs refactoring or improvement

Comments

@gbowne1
Copy link
Owner

gbowne1 commented Feb 27, 2023

Describe the bug
The Keyboard accessibility needs some minor improvements.

Expected behavior

Additional context
Add any other context about the problem here.

@gbowne1 gbowne1 added bug Something isn't working enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers css Issues with css a11y Issues with accessibity labels Feb 27, 2023
@gbowne1 gbowne1 added this to the Front End milestone Feb 27, 2023
@gbowne1
Copy link
Owner Author

gbowne1 commented Apr 11, 2023

We still have a number of keyboard accessibility issues along with Focus styling. We should work on a11y soon as we have a few more components done.

@puritybirir
Copy link

Hey @gbowne1 , I'd like to work on this issue

@gbowne1
Copy link
Owner Author

gbowne1 commented May 26, 2023

Ok @puritybirir

@puritybirir
Copy link

Hey @gbowne1, So far, I've only come across one keyboard accessibility issue, which relates to the dark mode/light mode button. However, I have found that all the other buttons and tabbing functions are working fine. On another note, I've also found a few more accessibility issues with the forms and buttons, as well as eight contrast errors.

I'd like to get your input on how to proceed. Should I fix these additional issues in my current pull request, or would it be better to create a new issue specifically for them? I'm open to hearing your thoughts on this.

@gbowne1
Copy link
Owner Author

gbowne1 commented May 27, 2023

Yes you may include those other fixes in your PR @puritybirir

I would only make a new issue if you feel its absolutely necessary.

Also make sure that all of the elements that need focus styling work correctly and that everything that needs an aria label get labeled.

@gbowne1 gbowne1 removed this from the Front End milestone Jun 5, 2023
@gbowne1 gbowne1 removed bug Something isn't working enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers css Issues with css a11y Issues with accessibity labels Jun 8, 2023
@gbowne1 gbowne1 added enhancement New feature or request help wanted Extra attention is needed css Issues with css a11y Issues with accessibity design medium-priority mobile labels Jun 8, 2023
@gbowne1
Copy link
Owner Author

gbowne1 commented Jun 14, 2023

@puritybirir are you still workimg on this?

@gbowne1 gbowne1 added frontend This is a frontend issue or PR needs-testing This needs testing feature This should be a new feature. hacktoberfest The hacktoberfest label devops this is a devops related feature or issue or PR labels Oct 6, 2023
@gbowne1 gbowne1 added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers css Issues with css a11y Issues with accessibity frontend This is a frontend issue or PR design medium-priority medium-complexity This issue is medium complexity tech-debt This needs refactoring or improvement and removed enhancement New feature or request help wanted Extra attention is needed css Issues with css a11y Issues with accessibity frontend This is a frontend issue or PR design medium-priority mobile needs-testing This needs testing medium-complexity This issue is medium complexity feature This should be a new feature. hacktoberfest The hacktoberfest label devops this is a devops related feature or issue or PR labels Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a11y Issues with accessibity css Issues with css design enhancement New feature or request frontend This is a frontend issue or PR good first issue Good for newcomers help wanted Extra attention is needed medium-complexity This issue is medium complexity medium-priority tech-debt This needs refactoring or improvement
Projects
Development

No branches or pull requests

2 participants