-
-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CSS] [A11y] Improve Keyboard accessibility #109
Comments
We still have a number of keyboard accessibility issues along with Focus styling. We should work on a11y soon as we have a few more components done. |
Hey @gbowne1 , I'd like to work on this issue |
Ok @puritybirir |
Hey @gbowne1, So far, I've only come across one keyboard accessibility issue, which relates to the dark mode/light mode button. However, I have found that all the other buttons and tabbing functions are working fine. On another note, I've also found a few more accessibility issues with the forms and buttons, as well as eight contrast errors. I'd like to get your input on how to proceed. Should I fix these additional issues in my current pull request, or would it be better to create a new issue specifically for them? I'm open to hearing your thoughts on this. |
Yes you may include those other fixes in your PR @puritybirir I would only make a new issue if you feel its absolutely necessary. Also make sure that all of the elements that need focus styling work correctly and that everything that needs an aria label get labeled. |
@puritybirir are you still workimg on this? |
Describe the bug
The Keyboard accessibility needs some minor improvements.
Expected behavior
Additional context
Add any other context about the problem here.
The text was updated successfully, but these errors were encountered: