Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kaustinen: genesis-time verkle transition is broken #264

Closed
gballet opened this issue Sep 6, 2023 · 1 comment
Closed

kaustinen: genesis-time verkle transition is broken #264

gballet opened this issue Sep 6, 2023 · 1 comment

Comments

@gballet
Copy link
Owner

gballet commented Sep 6, 2023

This is something that is most definitely also broken in the rebased beverly hills. This is an analysis of the bug, it will not be fixed for now as kaustinen will do the transition on block 1 anyway.

The code has been changed so that SetupGenesisBlockWithOverride will try to load the genesis from the db. If it finds one, it will check for its state, no longer using state.New but a MPT-specific function called HasLegacyNode: https://github.com/gballet/go-ethereum/blob/kaustinen-with-shapella/core/genesis.go#L345

If this function returns false (and it will as the verkle root at genesis is not a legacy node since it uses its own storage format, it will override the genesis to be DefaultGenesisBlock.

As a result, it will complain that the genesis hashes differ.

This will not be fixed before we use the state provider, as it would take a lot of time and will be obsolete soon.

@gballet
Copy link
Owner Author

gballet commented Sep 28, 2023

Fixed in #283, #284 , #285

@gballet gballet closed this as completed Sep 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant