Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jenkins views: fix some job names #1079

Merged
merged 9 commits into from
Nov 27, 2023
Merged

Jenkins views: fix some job names #1079

merged 9 commits into from
Nov 27, 2023

Conversation

scpeters
Copy link
Contributor

@scpeters scpeters commented Nov 20, 2023

Changes some ignition_gazebo to gz_sim and other ignition_ to gz_.

UPDATE:

I've added many more changes since that first commit. There are still some issues:

  • Some windows CI builds are missing for Fortress
  • The _dsl_gazebo_libs job doesn't seem to generate any focal builds for the citadel branches

Changes some ignition_gazebo to gz_sim and
other ignition_ to gz_.

Signed-off-by: Steve Peters <[email protected]>
@j-rivero
Copy link
Contributor

One of the reasons to implement the issue #1010 is to be able to generate all the collections set of jobs programmatically and do not hardcode values anymore. The implement still lacks of the -install- jobs to be able to replace the views in this PR but can provide all the ci-branch related job names in a log file together with the type of job and the collection. This is the current log https://gist.github.com/j-rivero/7c3468bae2e9ee39497131715c6add82.

It is easy to alpha-sort + grep that generated log file so two options:

  • Just copy/paste the alpha-order of all ci-branch and move the -install- jobs after. It will change current order and make things more difficult to human-read but would be great for completeness.
  • We leave the PR as it is and wait unlit the -install- jobs generation to replace it completely.

Whatever you prefer @scpeters

@scpeters
Copy link
Contributor Author

One of the reasons to implement the issue #1010 is to be able to generate all the collections set of jobs programmatically and do not hardcode values anymore.

ooh, I love this! 💯

The implement still lacks of the -install- jobs to be able to replace the views in this PR but can provide all the ci-branch related job names in a log file together with the type of job and the collection. This is the current log https://gist.github.com/j-rivero/7c3468bae2e9ee39497131715c6add82.

It is easy to alpha-sort + grep that generated log file so two options:

  • Just copy/paste the alpha-order of all ci-branch and move the -install- jobs after. It will change current order and make things more difficult to human-read but would be great for completeness.
  • We leave the PR as it is and wait unlit the -install- jobs generation to replace it completely.

I think I will paste the values from your gist into this branch just to get working views again, and then we can deprecate the explicit list for the auto-generated views

@scpeters
Copy link
Contributor Author

to the best of my ability, I've manually updated the job names to match the gist that @j-rivero listed in #1079 (comment). So this currently matches the names generated by our DSL jobs. We can discuss what we would like them to be named and work on auto-generating the views, but I think this PR could be merged as a short-term fix for the views

@j-rivero
Copy link
Contributor

We can discuss what we would like them to be named and work on auto-generating the views, but I think this PR could be merged as a short-term fix for the views

Agree. LGTM

@j-rivero j-rivero merged commit a41ab11 into master Nov 27, 2023
1 check passed
@j-rivero j-rivero deleted the scpeters/fix_gz_view branch November 27, 2023 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants