-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jenkins views: fix some job names #1079
Conversation
Changes some ignition_gazebo to gz_sim and other ignition_ to gz_. Signed-off-by: Steve Peters <[email protected]>
Signed-off-by: Steve Peters <[email protected]>
Signed-off-by: Steve Peters <[email protected]>
Signed-off-by: Steve Peters <[email protected]>
Signed-off-by: Steve Peters <[email protected]>
Signed-off-by: Steve Peters <[email protected]>
Signed-off-by: Steve Peters <[email protected]>
One of the reasons to implement the issue #1010 is to be able to generate all the collections set of jobs programmatically and do not hardcode values anymore. The implement still lacks of the It is easy to alpha-sort + grep that generated log file so two options:
Whatever you prefer @scpeters |
ooh, I love this! 💯
I think I will paste the values from your gist into this branch just to get working views again, and then we can deprecate the explicit list for the auto-generated views |
Signed-off-by: Steve Peters <[email protected]>
Signed-off-by: Steve Peters <[email protected]>
to the best of my ability, I've manually updated the job names to match the gist that @j-rivero listed in #1079 (comment). So this currently matches the names generated by our DSL jobs. We can discuss what we would like them to be named and work on auto-generating the views, but I think this PR could be merged as a short-term fix for the views |
Agree. LGTM |
Changes some
ignition_gazebo
togz_sim
and otherignition_
togz_
.UPDATE:
I've added many more changes since that first commit. There are still some issues: