Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to use tamper-proof hash algorithm (>= SHA256) #11

Open
BendingBender opened this issue Dec 27, 2022 · 1 comment
Open

Switch to use tamper-proof hash algorithm (>= SHA256) #11

BendingBender opened this issue Dec 27, 2022 · 1 comment

Comments

@BendingBender
Copy link
Contributor

BendingBender commented Dec 27, 2022 •
edited
Loading

This script uses SHA-1 to verify checksums. SHA-1 isn't considered tamper-proof any more, see: https://shattered.io/. We should switch to use a safer hash algorithm, at least SHA-256 (SHA-2).

I'd make a PR if you're interested.
@gavinuhma
Copy link
Owner

Yes please @BendingBender

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gavinuhma @BendingBender