SSR in Develop #28138
Replies: 44 comments 139 replies
-
|
I've tested it on kent c dodds site and I see It didn't show without the flag |
Beta Was this translation helpful? Give feedback.
-
|
tested his site and code changes aren't applying cleanly so trigger a refresh of the page. Not sure if this is something goofy with HMR, his site, or dev ssr. I suspect one of the early as I couldn't reproduce it on another site. Others — if HMR breaks on your site, let us know! |
Beta Was this translation helpful? Give feedback.
-
|
Regarding lazy bundling, is it expected to work with the MDX plugin yet? Seems like the MDX plugin still eagerly builds everything when |
Beta Was this translation helpful? Give feedback.
-
|
Looks like you're in the wrong umbrella issue? But to answer your question — yes — MDX adds all of its code outside of pages so isn't affected by that. If you want to check out Query on Demand — that does help with most MDX setups #27620 |
Beta Was this translation helpful? Give feedback.
-
|
Ah the link in the release notes pointed here: https://github.com/gatsbyjs/gatsby/blob/master/docs/reference/release-notes/v2.27/index.md#experimental-lazy-page-bundling-in-development I'll repost my comment in the correct discussion, but briefly, it doesn't seem like Query on Demand helps in my case, most of my MDX files have imports using a fairly expensive webpack loader. |
Beta Was this translation helpful? Give feedback.
-
|
Hey everyone, I’m running into an issue that I’m fairly convinced is this issue (or related to SSR), but the additional debug features are not working on my end. Context: I’m building a website over at https://github.com/addisonschultz/Immaterial (immaterialcorp.com), and everything for the most part work and appears to be fine. The main issue I’m running into, is that when you navigate to certain pages from external links / navigating back from external links (immaterialcorp.com/cart OR immaterialcorp.com/product-name [this issue appears on all dynamically generated pages]), the CSS is not applied correctly. Looking into this, it seems that the incorrect After looking into this, it seems directly related to:
I was looking into this issue/PR, and was wondering if this experimental development build would help me figure out what was going on, but I’m not getting any logs, nor expected (incorrect css) behavior when running this (Again, my styles are only incorrect on prod). I’m a bit confused at what I should try or do next. I’ve even hard coded the styles into css to see if a forced element style would help, but the wrong Any help would be appreciated, even if it’s just help getting this dev feature working so I can debug more on my end. Thanks in advance! Expected (dev):
Actual (prod /
|
Beta Was this translation helpful? Give feedback.
-
|
No worries, and thanks for the update. I created a new branch upgrading I've made the branch here: https://github.com/addisonschultz/Immaterial/tree/upgrade/gatsby Do you have any other suggestions on where I could start looking? I'm serving all of my |
Beta Was this translation helpful? Give feedback.
-
|
did you add the |
Beta Was this translation helpful? Give feedback.
-
diff --git a/gatsby-config.js b/gatsby-config.js
index 454c78b..2e3f74a 100644
--- a/gatsby-config.js
+++ b/gatsby-config.js
@@ -1,4 +1,7 @@
module.exports = {
+ flags: {
+ DEV_SSR: true,
+ },
siteMetadata: {
title: `Immaterial`,
description: `VINTAGE, CONSIGNMENT, ART & MUSIC.`,My changes locally. Can you list the steps to reproduce the bug you're seeing? Perhaps record a little video? Thanks for helping test! |
Beta Was this translation helpful? Give feedback.
-
|
Hey Kyle, thanks again for helping me with this, hopefully this is helpful on your end as well. Right now, I have everything on As a quick overview, here's the situations where the styles are loading correctly and incorrectly: NO ISSUES: ISSUES: It loads the styles correctly only when navigating the site through I've made a video explaining some of the oddness that I'm experiencing: https://www.dropbox.com/s/nbu56193n6c8u1e/bugs.mov?dl=0 Is there anything I should be looking for/at specifically? Many thanks in advance! UPDATE 12/01/2021: |
Beta Was this translation helpful? Give feedback.
-
|
Ok the reason the error wasn't happening in dev is the same as discussed below #28138 (comment) Once the PR I made is in, you'll experience the same problem in dev. The root problem though is you're using window.innerWidth to render https://github.com/addisonschultz/Immaterial/blob/69a042fc614885a5145e938728ecd74fcda57599/src/pages/index.js#L39 This doesn't work during SSR as |
Beta Was this translation helpful? Give feedback.
-
|
I'm using exports.onCreateWebpackConfig = ({ stage, loaders, actions }) => {
if (stage === "build-html") {
actions.setWebpackConfig({
module: {
rules: [
{
test: /react-leaflet-geodesic/,
use: loaders.null(),
},
],
},
})
}
}This does not work with SSR in develop. How do I work around that issue with SSR in develop? |
Beta Was this translation helpful? Give feedback.
-
|
hmm yeah odd indeed — |
Beta Was this translation helpful? Give feedback.
-
|
Turns out it only worked randomly ... now it is back to the scrambled page in the upper screenshot. :/ |
Beta Was this translation helpful? Give feedback.
-
|
It's probably a separate problem not related to |
Beta Was this translation helpful? Give feedback.
-
|
Is there a way to highlight this fix more broadly? The documentation only says |
Beta Was this translation helpful? Give feedback.
-
|
@acarnwath ah right — we've forgotten to update that page #29686 |
Beta Was this translation helpful? Give feedback.
-
|
I have a hydration bug that didn't show up in development even though I'm using |
Beta Was this translation helpful? Give feedback.
-
|
thank you for your excellent reproduction! Looking at it reminded me of this... very important TODO we forgot about haha gatsby/packages/gatsby/cache-dir/app.js Lines 122 to 125 in 2c6c42c |
Beta Was this translation helpful? Give feedback.
-
|
Changing from |
Beta Was this translation helpful? Give feedback.
-
|
PR #29016 |
Beta Was this translation helpful? Give feedback.
-
|
Hello We are struggling with css delivery when using When where we expected this: This also happens when we type in URLs and try to load these directly, but it seems like the css is delivered as expected every time when visiting We are using following versions of related packages: Setting Please let me know if you need more information or if I should submit a bug report! Other than that, thank you for a great product and exciting features lately! Edit: |
Beta Was this translation helpful? Give feedback.
-
|
Beta Was this translation helpful? Give feedback.
-
|
🙏 yup, the PR is in the Thanks for testing and glad it resolved things (for your site at least)! Keep the bug reports coming. |
Beta Was this translation helpful? Give feedback.
-
|
and out https://github.com/gatsbyjs/gatsby/blob/master/docs/docs/reference/release-notes/v2.31/index.md |
Beta Was this translation helpful? Give feedback.
-
|
Seems to work seamlessly now. Used it throughout the day. Thank you for the quick solution! Now we're able to get the benefits from the dev-ssr which we believe can ease the onboarding of new developers to our gatsby project. |
Beta Was this translation helpful? Give feedback.
-
|
excellent! |
Beta Was this translation helpful? Give feedback.
-
|
I can't read the logs My gatsby-config.js: module.exports = {
flags: {
DEV_SSR: false
},
siteMetadata: {
title: "Wordpress",
},
plugins: [
{
resolve: "gatsby-source-wordpress-experimental",
options: {
url: "http://localhost:8080",
},
},
"gatsby-plugin-sharp",
"gatsby-plugin-sitemap",
"gatsby-plugin-offline",
{
resolve: "gatsby-plugin-manifest",
options: {
icon: "src/images/icon.png",
},
},
"gatsby-transformer-sharp",
{
resolve: "gatsby-source-filesystem",
options: {
name: "images",
path: "./src/images/",
},
__key: "images",
},
],
};info: |
Beta Was this translation helpful? Give feedback.
-
|
Can you open a new issue as it's not related directly to dev-ssr? This is a terminal rendering bug that's affecting a % of users but I haven't been able to reproduce. Perhaps, looking at your info, it's a linux thing? Getting all terminals to work the same is... challenging. If you run |
Beta Was this translation helpful? Give feedback.
-
|
Yes, It's not related directly to dev-ssr, it's related to all flags. |
Beta Was this translation helpful? Give feedback.
-
|
This should be fixed on the latest versions — #29472 |
Beta Was this translation helpful? Give feedback.
-
|
Hi, After going from Gatsby 2.29.3 to 2.31.1, source map seems to be gone even with DEV_SSR: false. Chrome DevTools now only shows webpack commons.js in Sources. With flag DEV_SSR:false, the following reproduces the issue (yarn install + gatsby clean run between each case) Source missing in Chrome: Source showing in Chrome package.json Any idea if related to this flag? |
Beta Was this translation helpful? Give feedback.
-
|
I suspect it's not related but it might be. Do you have a reproduction we could look at? |
Beta Was this translation helpful? Give feedback.
-
|
Sure! Here's a super minimal example: https://codesandbox.io/s/ic8eh |
Beta Was this translation helpful? Give feedback.
-
|
Is this the source maps for Chakra or for your code? I do see source maps in the latest for code |
Beta Was this translation helpful? Give feedback.
-
|
For my own code - writing some fairly JS-heavy pages as part of the site so need to be able to debug :) Neither locally on the Mac or when opening a Chrome browser through codesandbox I see any source map with v2.30. How did you get that working? :)
|
Beta Was this translation helpful? Give feedback.
-
|
heh not sure. Source maps are weird sometimes IME and I never quite figure out why they stop working and why they come back. |
Beta Was this translation helpful? Give feedback.
-
|
Found a corner case that is not caught by DEV_SSR but handled correctly by "gatsby build" (build failing): I have a couple of worker threads that are compiled by webpack (with the help of "gatsby-plugin-workerize-loader"). |
Beta Was this translation helpful? Give feedback.
-
|
Oh interesting. Is there any console output in this case? |
Beta Was this translation helpful? Give feedback.
-
|
On the condition of that my understanding of SSR in DEV together with fast reload enabled is correct: the SSR-generated version of a page will differ while doing the hydration process because the fast reload -"version" got a 'shadow-modal' that the SSR-version lacks. The discrepancy between these two versions generates a warning like the on screenshotted below.
This shadow-modal is needed to present compilation/linting/etc warnings and errors on an overlay in the browser, so I get why it's there. But to mute this warning I'm wondering if it would be a good idea to add the fast reload modal to the SSR-rendered version, only in dev mode while both DEV_SSR and FAST_REFRESH is enabled, so the the SSR and CSR version doesn't have this diff? My motivation to suggest this is that I see we easily create diffs in the SSR and CSR output in our code base ourself, like when we conditionally determine things based on if we are on the server or in the browser (like accessing |
Beta Was this translation helpful? Give feedback.
-
Sounds more pragmatic. Great👍 |
Beta Was this translation helpful? Give feedback.
-
|
So has this been fixed @KyleAMathews -- because I see this error on every page load. and I get a message saying:
|
Beta Was this translation helpful? Give feedback.
-
|
Just got a fix merged into master #29692 master is now for upcoming v3 launch but I've marked it as one we can/should backport to v2 for release |
Beta Was this translation helpful? Give feedback.
-
|
@KyleAMathews I've still got this issue even with gatsby 3.2.0. I'm using <main>
<h1>Lovely Page Title</h1>
<div>{page}</div>
</main>Unfortunately the page is not generated for the server HTML (although a normal gatsby build will generate this correctly). Therefore when the content loads on the client side, the same warning is generated: Interestingly for "pages" it works correctly (no error message), for "templates", i.e. stuff that is created with Could that be the smoking gun? |
Beta Was this translation helpful? Give feedback.
-
|
@KyleAMathews did you see the above? |
Beta Was this translation helpful? Give feedback.
-
|
Intermittently get this white page error on local environment, only occurs with the new DEV_SSR enabled. seems related to |
Beta Was this translation helpful? Give feedback.
-
|
I can reproduce this when I don't have the |
Beta Was this translation helpful? Give feedback.
-
|
I added a PR to validate this plugin's options #29688 |
Beta Was this translation helpful? Give feedback.
-
|
There's an issue with [gatsby-image] Issue with SSR, expected server HTML to contain a matching picture in div |
Beta Was this translation helpful? Give feedback.
-
|
I'm getting the same warning. |
Beta Was this translation helpful? Give feedback.
-
|
Same - easily reproducable on vanilla gatsby-starter-default |
Beta Was this translation helpful? Give feedback.
-
|
This is a hydration bug with |
Beta Was this translation helpful? Give feedback.
-
|
Not sure if this is the right place to report but I'm consistently getting an error related to using the minified version of react when running in combination with vercel serverless functions. ie
|
Beta Was this translation helpful? Give feedback.
-
|
That's correct. I run https://vercel.com/blog/vercel-dev#gatsby-and-node.js-functions |
Beta Was this translation helpful? Give feedback.
-
|
Having exactly the same issue.. same screen with the same error... starting the devserver with gatsby develop as usual, and we have only one version of react installed |
Beta Was this translation helpful? Give feedback.
-
|
hmm can't reproduce with |
Beta Was this translation helpful? Give feedback.
-
|
ok reproduced it w/ a site w/ gatsby-plugin-mdx — are the rest of you using mdx as well? |
Beta Was this translation helpful? Give feedback.
-
|
Actually I think it's just using hooks. Anyways, this PR should fix things #29620 |
Beta Was this translation helpful? Give feedback.
-
|
Hi, I encountered this error today: I guess I need to use the solution described here: https://www.gatsbyjs.com/docs/debugging-html-builds/#how-to-check-if-window-is-defined |
Beta Was this translation helpful? Give feedback.
-
|
I ended up disabling the feature by adding into gatsby-config.js. I am not planning to add SSR to my project at this moment but if I were to do so, I prefer to catch errors on develop and not on build. I would've used this feature. |
Beta Was this translation helpful? Give feedback.
-
|
This feature should only catch problems that'd prevent your site from building. Does |
Beta Was this translation helpful? Give feedback.
-
|
Yes, I do have it. Here is the output: I guess I'll have to re-enable the flag and fix it |
Beta Was this translation helpful? Give feedback.
-
|
This feature is the bee's knees. It's helped me avoid and diagnose a couple of nasty prod bugs already. ⭐ |
Beta Was this translation helpful? Give feedback.
-
|
i found an issue related to this discussion with dev_ssr true. I resolved it, was from a timeout Have a look on |
Beta Was this translation helpful? Give feedback.
-
|
I'm also getting this error |
Beta Was this translation helpful? Give feedback.
-
|
I just noticed that setting
|
Beta Was this translation helpful? Give feedback.
-
|
I can confirm that I am on Gatsby 4.2.0 and with However, if I set |
Beta Was this translation helpful? Give feedback.
-
|
This leads me to wonder if When I add |
Beta Was this translation helpful? Give feedback.
-
|
Last note here I promise. Even when having the environment variable set in my ZSH config and having it in my gatsby config, I still get this printed in the terminal when using Gatsby develop: @dko-slapdash , did you get some sort of confirmation in the console that |
Beta Was this translation helpful? Give feedback.
-
|
Is
Issue #30750 |
Beta Was this translation helpful? Give feedback.
-
|
i resolved this issue with aria-current mismatch from link with dev-ssr to patch it's described here |
Beta Was this translation helpful? Give feedback.
-
|
Is there a way to have output CSS with dev-ssr enabled? I see the html being rendered, but no css is emitted with my setup Can we use |
Beta Was this translation helpful? Give feedback.
-
|
when location.pathname rendered from Server is not ending by a trailing slash and window.location.pathname is ending by trailing slash from client it's result by aria-current mismatch from gatsby-link Somebody should to check that. I did a patch to resolve this mismatch here |
Beta Was this translation helpful? Give feedback.
-
|
Hi All I'm developing a new Gatsby theme and using yarn workspaces as dev environment. I have been developing sites in Gatsby before and I must say it has been extremely frustrating to have dev_ssr on and a huge pain compared to not having it. The main frustration is that whenever a change/mismatch big or small (sometimes very tiny) between the server and client occurs it just crashes and I have to create a new dev build. This sometimes happens if I just add/remove a console.log.. In the browser: in the terminal: The intention of giving the SSR errors right away without having to do builds to get them is awesome, but then the errors have to be descriptive or else they just slow down development a lot and are the cause of a lot of frustration. I hope this is of some use to you. |
Beta Was this translation helpful? Give feedback.
-
|
Running into the exact same issue! |
Beta Was this translation helpful? Give feedback.
-
|
Getting the same issue. Not sure how to solve it yet :( |
Beta Was this translation helpful? Give feedback.
-
Yes. We in my team have seen this issue quite often lately (many times a day), compared to a couple of weeks ago. I have not been able to recognize if this is connected to changes in components used in wrapPageElement (which, in my perspective, would make more sense) or if it is connected to changes in general. |
Beta Was this translation helpful? Give feedback.
-
|
While running I isolated the issue to the Helmet component from react-helmet. I was using this code in a page template: I removed that component from my template and now I am able to refresh the page without getting the SSR error. |
Beta Was this translation helpful? Give feedback.
-
|
Hi @iamkimchico, I faced something similar which was a pain as the error wasn’t descriptive enough to find where the error is coming from. error: {"codeFrame":"No codeFrame could be generated","sourcePosition":null,"sourceContent":null} fix: For me, I had to review my previous changes and I found that I had two graphql queries that had the same name which was conflicting, and updating that did the trick. Hope this helps ✌️ |
Beta Was this translation helpful? Give feedback.
-
IntroHey team, I just spun up a new Gatsby project and I got six staging features. I theme with Chakra-ui and after chasing a bug for a while I discovered it was the feature Error Message react_devtools_backend.js:2842 Warning: Prop `className` did not match. Server: "chakra-heading css-0" Client: "chakra-heading css-1gfmyfr"Project Details
module.exports = {
// ..
flags: {
PARALLEL_SOURCING: true,
LMDB_STORE: false,
FAST_DEV: true,
DEV_SSR: true,
DEV_WEBPACK_CACHE: true,
PRESERVE_FILE_DOWNLOAD_CACHE: false,
},
// ...
}
//...
"dependencies": {
"@chakra-ui/icons": "^1.0.15",
"@chakra-ui/react": "^1.6.6",
"@emotion/react": "^11.4.1",
"@emotion/styled": "^11.3.0",
"@mdx-js/mdx": "^1.6.22",
"@mdx-js/react": "^1.6.22",
"framer-motion": "^4.1.17",
"gatsby": "^3.11.1",
"gatsby-plugin-image": "^1.12.0",
"gatsby-plugin-layout": "^2.12.0",
"gatsby-plugin-manifest": "^3.12.0",
"gatsby-plugin-mdx": "^2.12.0",
"gatsby-plugin-prettier-eslint": "^1.0.6",
"gatsby-plugin-react-helmet": "^4.12.0",
"gatsby-plugin-react-svg": "^3.0.1",
"gatsby-plugin-sass": "^4.12.0",
"gatsby-plugin-sharp": "^3.12.0",
"gatsby-source-datocms": "^2.6.16",
"gatsby-source-filesystem": "^3.12.0",
"gatsby-transformer-sharp": "^3.12.0",
"react": "^17.0.1",
"react-dom": "^17.0.1",
"react-helmet": "^6.1.0",
"sass": "^1.38.0"
},
/...
import './src/assets/sass/_index.scss';
import { CSSReset, ChakraProvider } from '@chakra-ui/react';
import React from 'react';
const theme = extendTheme({
// ...
fonts: {
heading: "'Montserrat Alternates', 'Montserrat', sans-serif",
body: 'Montserrat',
},
// ...
});
export const wrapRootElement = ({ element }) => (
<ChakraProvider theme={theme}>
<CSSReset />
{element}
</ChakraProvider>
);
import { Heading, Box } from '@chakra-ui/react';
import * as React from 'react';
// markup
const IndexPage = () => {
return (
<Box>
<Heading as="h2" size="2xl">
(2xl) In love with React & Next
</Heading>
</Box>
);
};
export default IndexPage;Thanks for all the hard work! 🙌 💪 |
Beta Was this translation helpful? Give feedback.
-
|
Hi: I set to True the FAST_REFRESH flag but didn't work. Thanks. |
Beta Was this translation helpful? Give feedback.
-
|
An issue I've experienced is that when We have an in-house library built with styled components so I did suspect and rolled them back to a few versions to make sure it wasn't an issue there - which it wasn't. Turns out |
Beta Was this translation helpful? Give feedback.
-
|
I'm having a lot of trouble in finding the cause of DEV_SSR bugs
It turns out that the page listed is not an issue and the .call error is even more obscure |
Beta Was this translation helpful? Give feedback.
-
|
after wrapping the gatsby cli in my own stderr and stdout i was able to get something: When using loadable and DEV_SSR, should we use hydrate? https://www.gatsbyjs.com/plugins/gatsby-plugin-loadable-components-ssr/ |
Beta Was this translation helpful? Give feedback.
-
|
After restarting gatsby, I'm also getting this Any idea? |
Beta Was this translation helpful? Give feedback.
-
|
Update: I have disable all webpack cache with export const onCreateWebpackConfigFunction: GatsbyNode['onCreateWebpackConfig'] = (
{ stage, rules, loaders, plugins, actions, getConfig, reporter, store },
options
) => {
const pluginOptions = options as unknown as GatsbyPluginTsCacheOptions;
/**
* Retrieve the initial gatsby webpack config
*/
const config = getConfig() as Configuration;
if (!config) {
return void 0;
}
reporter.info(`[${pluginOptions.pluginName}]: replacing cache config`);
/**
* Replace the default caching strategy
*/
config.cache = undefined;
actions.replaceWebpackConfig(config);And I no longer have crashes while refresh the page (with DEV_SSR enabled) |
Beta Was this translation helpful? Give feedback.
-
|
Update: updating to gatsby-plugin-loadable-components-ssr v3.4.0 seemed to have helped |
Beta Was this translation helpful? Give feedback.
-
|
How did you wrap the gatsby cli in your own stderr and stdout ? |
Beta Was this translation helpful? Give feedback.
-
|
We've re-enabled |
Beta Was this translation helpful? Give feedback.
-
|
DEV_SSR Works great.. however when doing a build in gatsby@next I get (note it works fine in 4.17) |
Beta Was this translation helpful? Give feedback.
-
|
I just upgraded to Gatsby 4.24 from 4.17, and I have to explicitly disable I believe this is the same error reported #36678 with a reproduction link |
Beta Was this translation helpful? Give feedback.
-
|
Like @phil-lgr I am having a lot of trouble finding the cause of errors during SSR in develop. For example: Failed to Server Render (SSR)
Error message:
React.Children.only expected to receive a single React element child.
File:
node_modules/@emotion/stylis/dist/stylis.esm.js:602:1
Stack:
WebpackError: React.Children.only expected to receive a single React element child.
at node_modules/@emotion/stylis/dist/stylis.esm.js:602:1
at node_modules/styled-components/dist/styled-components.esm.js:1:13845
I'm fairly confident that the error is occurring in our component library, but have already sunk a few hours into trying to work out what this error in particular could be. Any suggestions for what to try next? |
Beta Was this translation helpful? Give feedback.
-
|
I am getting the same errors as @joerobot after upgrading to Gatsby 5.7 and find this impossible to debug. Reported line numbers and files seem to be random, and debugging Gatsby develop does not help because the renderHTML step is loaded off to a worker (which means breakpoints don't work). |
Beta Was this translation helpful? Give feedback.
-
|
I upgraded Gatsby from v4.17.2 to v 5.8.1 and got the exact same error message. This is 100% reproducible by closing all browser tabs, and restart development server with cache cleaned and SSR enabled. After spending couple of hours debugging the issue, I was able to locate the root cause, however I didn't have a solution yet. gatsby/packages/gatsby-plugin-styled-components/src/gatsby-ssr.js Lines 7 to 18 in c4d2d0f If we try to add The function definition of React.Children.only can be found at [here](https://github.com/facebook/react/blob/790ebc962de573a37e4755207eba91b07a0fa172/packages/react/src/ReactChildren.js#L3300, where it will perform I didn't seems to experience |
Beta Was this translation helpful? Give feedback.
-
|
@just-small-potato I'm having the same issue, did you ever find a solution? Gatsby support seems to have gone silent. |
Beta Was this translation helpful? Give feedback.
-
|
We are having the same issue |
Beta Was this translation helpful? Give feedback.
-
|
I’m not sure if this is the right place to ask but how is there any documentation on how to render SSR pages in production? I have a custom node sever that serves built pages but how do I server SSR pages as gatsby develop does? Gatsby develop is not meant to run in prod, is it? |
Beta Was this translation helpful? Give feedback.
and others
-
This is an issue for discussing & reporting bugs for the upcoming SSR in development feature. The coming feature enables SSR in development so certain bugs that previously only show up in builds (like trying to access the
windowobject) will now be seen during development which will help speed up fixing them.Original PR: #27432
Original issue: #25729
How to test
Add the
DEV_SSRflag to yourgatsby-config.js:Migrating custom webpack config
If you've added custom webpack logic for the
build-htmlstage e.g. to exclude a module from loading, you'll also need to add these rules for thedevelop-htmlstage.Beta Was this translation helpful? Give feedback.
All reactions