Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decrease the amount of Dockerfile commands #1

Closed
nanory opened this issue Oct 25, 2023 · 1 comment · Fixed by #4
Closed

Decrease the amount of Dockerfile commands #1

nanory opened this issue Oct 25, 2023 · 1 comment · Fixed by #4
Assignees
Labels
kind/enhancement Enhancement, improvement, extension status/closed Issue is closed (either delivered or triaged)

Comments

@nanory
Copy link
Contributor

nanory commented Oct 25, 2023

What would you like to be added:
After reviewing the Dockerfiles in this repo, I noticed that it uses a lot of Dockerfile commands for similar tasks (e.g. installing applications etc) which lead to new container layers.

By combining comannds, you can decrease the amount of layers it creates.

Why is this needed:
Some design patterns suggest to keep the container layers as low as possible. We could use this approach to also update the Dockerfiles and add some more comments to it, so it's clear for externals what this containers contains and why it needs specific packages for example.

@nanory nanory added the kind/enhancement Enhancement, improvement, extension label Oct 25, 2023
@alee-ntap alee-ntap self-assigned this Oct 27, 2023
@nanory
Copy link
Contributor Author

nanory commented Oct 30, 2023

First adjustments have been done in #4 . This change is currently in review

@nanory nanory closed this as completed in #4 Oct 31, 2023
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Enhancement, improvement, extension status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants