Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add logging #12

Open
Tracked by #3
JasirZaeem opened this issue Jul 14, 2021 · 3 comments
Open
Tracked by #3

Add logging #12

JasirZaeem opened this issue Jul 14, 2021 · 3 comments
Assignees
Labels
improvement To request improvements and features in c0d3r

Comments

@JasirZaeem
Copy link
Member

JasirZaeem commented Jul 14, 2021

Need logging in the bot to record errors for better awareness of bugs and help in investigating them.

Current state

Errors are sent as response to the caller of the api. #11 adds logging using console.error in the errorHandler middleware which should make the errors visible on the caprover dashboard where c0d3ris deployed.

Proposed Solution

Add winston to log errors and use winston-logflare transport to forward them to our logflare account.

@JasirZaeem JasirZaeem mentioned this issue Jul 14, 2021
8 tasks
@JasirZaeem JasirZaeem added the improvement To request improvements and features in c0d3r label Jul 14, 2021
@JasirZaeem JasirZaeem self-assigned this Jul 14, 2021
@flacial
Copy link
Member

flacial commented Jul 25, 2023

Or Sentry

@JasirZaeem
Copy link
Member Author

Sentry != Logging. Sentry is a more specialized service, aimed at tracking things that are rarer/exceptional and need immediate action like app crashes, performance regressions etc. and including extra information with them that is necessary like stack traces. Logging is more general event tracking, you'd use sentry in addition to logging. Where events that are relevant to things sentry is for get sent to sentry in addition to logs.

User tries to login with incorrect credentials -> logs
User makes a post that crashes the app -> logs + sentry

Tracking every time a new feature is used -> logs, then you can analyze the logs maybe after a month to measure adoption.
New feature crashing the mobile app -> logs + sentry

@flacial
Copy link
Member

flacial commented Jul 27, 2023

@JasirZaeem Thanks for explaining the difference between the two!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement To request improvements and features in c0d3r
Projects
None yet
Development

No branches or pull requests

2 participants