Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do you have any plans to support CJK? #6

Open
black7375 opened this issue Sep 25, 2020 · 2 comments
Open

Do you have any plans to support CJK? #6

black7375 opened this issue Sep 25, 2020 · 2 comments
Labels
enhancement New feature or request

Comments

@black7375
Copy link

Necessity

CJK characters are not included in Hack or JetBrains Mono.

As one of the Asian users, CJK characters are often included in strings or comments.
Even if it's annoying, we need to set the fallback after resizing it with a tool that fits the size like Font style matcher.

It's a painful process.
If a high-quality font supports CJK, I think it will help many users.

Some resource

This is a helpful resource.

Chinese

Considering that you are from Hong Kong in your profile, I think you know better than me.

Japanese

I looked for Japanese-related fonts.

Article

Font

After reading the introductory articles, it would be better to merge them based on HackGen.
I hope someone who knows Japanese well can help.

Korean

is Best Font.

@gaplo917
Copy link
Owner

gaplo917 commented Sep 29, 2020

Hi @black7375, this project mainly focuses on creating a Hack ligatured font. For a general-purpose to add ligature to the font, you may want to check out this Repository https://github.com/ToxicFrog/Ligaturizer/tree/master

In my understanding, the most difficult part about creating a source code font with CJK support is to tune the size of the font "Box" that makes CJK characters work harmoniously with the source code. Thus, rather than solving the difficulties in this repo, using a patched CJK font and add ligatures on it should more match the project plan.

HackGen is a good choice and can be considered as one of the source font to patch ligature in it. Thank you for the suggestion.

However, D2Coding is not Hack patched Korean font. I would suggest you could use the Ligaturizer or fork this repository to make necessary changes to support D2Coding.


I never think of creating a Hack Chinese patched font. Maybe, it is because most of the Hong Kong developers write English comments and documentations in their codebase, at least for me, don't encounter any issues with source code and Chinese font.

But, I still started google and found some interesting issues when using Hack with Chinese, i.e. source-foundry/Hack#341

Anyway, thank you for your insight. Maybe there is a separate project to create a Hack Chinese patched font and might be I could R&D a generic handling of resizing a font "Box" that could apply Japanese and Korean too.

@black7375
Copy link
Author

Thank you for your kind reply.

Most of my work is in English too, but sometimes I use it as a fallback in the editor(vscode, emacs) or on the web because of a need.

If you have work to do later or write down information for someone to do it, rescaling D2Coding by about 1.17 times will match Hack.

@gaplo917 gaplo917 added the enhancement New feature or request label Oct 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants