Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNAPTRACE_TRACE_SELF typo at snaptrace.c #363

Closed
AlexeyKozhevin opened this issue Aug 15, 2023 · 2 comments · Fixed by #371
Closed

SNAPTRACE_TRACE_SELF typo at snaptrace.c #363

AlexeyKozhevin opened this issue Aug 15, 2023 · 2 comments · Fixed by #371

Comments

@AlexeyKozhevin
Copy link
Contributor

viztracer/src/viztracer/modules/snaptrace.c

Line 1251 in cb8934f

} else if (kw_log_async == 0) {

Potentially, it's a typo: the second check is for kw_log_async instead of kw_trace_self.
@gaogaotiantian
Copy link
Owner

This is true, do you want to just fix it with a PR? I can do it if you feel this is too trivial.

@AlexeyKozhevin
Copy link
Contributor Author

Yes, I'll do

@gaogaotiantian gaogaotiantian linked a pull request Oct 4, 2023 that will close this issue
Fixed a typo for trace self #371
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixed a typo for trace self gaogaotiantian/viztracer
2 participants
@gaogaotiantian @AlexeyKozhevin