Getting error 500 for very few vnets

[rasselmaliyekkal]

First of all thank you so much for this solution, we were using this solution from last few months, recently I observed, this solution is not working in rare cases, im not able to figure out whats difference between working vnets and non working.

There are no access related issues, I tried created new subnet in new RG and tested, still I get this error.

[rasselmaliyekkal]

When I deleted the subnet, it's working. Strange!!! In order not to miss any updates to the code, i pushed recent changes to functionapp. When i again created same subnet, its not working.. Kindly help.

[rasselmaliyekkal]

@gamullen - What I observed, this solution is working for all existing created vnets, issue is only with newly created vnets even if it having exact same configuration with working vents. can you please test and confirm.

[rasselmaliyekkal]

@craigthackerx @AUsfy @gamullen - Kindly help to validate this is not a error that im alone facing, to rule out mistakes in the way i deployed the solution.

All new azure Vnets im facing the issue but not with old one

[AUsfy]

I'll check and let you know

[AUsfy]

After investigation I discovered that a field in subnets data retrieved from Azure is unexpectedly null. I think it may be related to a recent change of behavior in Azure api side which could explain why the solution is working for old vnets but not for new ones.
I made a fix that uses the right field. @rasselmaliyekkal could you test if it's working for you ?

[rasselmaliyekkal]

@AUsfy Thank you so much, issue is fixed. I think you can proceed with merging this change to main. [ found another issue ]

[rasselmaliyekkal]

@AUsfy - Sorry, another issue occurred with this change, now it's not able to identify the existing subnet ranges. Getting an overlapping proposed CIDR as result.

[AUsfy]

@rasselmaliyekkal To understand well the new problem, is it only for old existing vnets ?

[rasselmaliyekkal]

@AUsfy well i haven't verified proposed cidr for new Vnets are overlapping or not.

[AUsfy]

I've tested in my side and it's working for new vnets, unfortunately I don't have old existing vnets in my environment to check.
I've made another change to the fix to support all cases. Could you check it please ?

[rasselmaliyekkal]

@AUsfy - Still it is providing subnet range which is overlapping with existing subnet. And no issues with new Vnet.

[AUsfy]

Thanks for the tests @rasselmaliyekkal, I just realized I missed a line in the fix in which I didn't use the correct variable.
I just made another PR to fix it #10 . Could you please test it ?

[rasselmaliyekkal]

@AUsfy this time it worked!!!, Thank you so much, appreciate your quick response and resolution.

[AUsfy]

Great news ! wlcm ^^

[gamullen]

Merged. Thanks for the help!