Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide a way to override liveblog pusher credentials #100

Open
rthideaway opened this issue May 2, 2017 · 1 comment
Open

Provide a way to override liveblog pusher credentials #100

rthideaway opened this issue May 2, 2017 · 1 comment

Comments

@rthideaway
Copy link

rthideaway commented May 2, 2017

Currently the following is not possible:

$config['liveblog.notification_channel.liveblog_pusher'] = [
  'app_id' => $overriden_pusher_app_id,
  'key' => $overriden_pusher_key,
  'secret' => $overriden_pusher_secret,
];

It's very important for us to not store sensitive data in repository so we would like to use config overrides instead in settings.php. So content of liveblog.notification_channel.liveblog_pusher.yml will be something symbolic like:

app_id: 'app_id_placeholder'
key: 'key_placeholder'
secret: 'secret_placeholder'

And then we override pusher credentials by variables, which are injected to settings.php and are not part of project repository. For this we need the pusher to provide a way to override config. With current set up it's not possible since config variables are loaded from yaml only and ignoring config overrides in settings.php

@rthideaway
Copy link
Author

Currently I am using the following quick patch to get config overrides working. https://www.drupal.org/files/issues/2874796-2-liveblog-let-config-override.patch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants