-
-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add build option for es modules #63
Comments
Whats the benefit of that in the context of
|
Does |
Remove what? Rollup is relevant only if it can determine (statically) that something is not being used. Tree shaking will be of value only to large libraries (think lodash). Purpose built libraries like |
You're right. At best it could get rid of |
The benefit of including a |
I am all pro-rollup approach, I am just not happy with the-Rollup. I think the user base is too insignificant to cater for. This will land in one shape or form in Node.js v8 and webpack v3. |
What I'm proposing isn't specific to Rollup. It's good practice for any library. Especially since it would match the rest of the React ecosystem. |
|
|
So before I publish a fork on npm, that's a hard no on adding es modules to your build? |
Go ahead with a fork. I will need to read up about the module situation in Node.js land today and whats the consensus and long term strategy. This is not going to happen today or tomorrow. |
Redux (and a lot of other React libs) have a ES2015 modules version of the build: https://github.com/reactjs/redux/blob/master/package.json#L24
This is really handy for tools like Rollup, since the
"module"
key in package.json can be pointed at./es/index.js
. I'm using a fork of redux-immutable with these builds and it works well.Would you consider a PR that adds multiple build outputs to match how Redux is built?
The text was updated successfully, but these errors were encountered: