.git suffix inconsistently enforced

[willstott101]

When creating a new repo, a .git suffix is appended here:

node-git-server/src/git.ts

Line 288 in e25c481

if (!/\.git$/.test(repo)) repo += '.git';

and it appears to be enforced in list, but not everywhere

However the .git suffix is not a requirement anywhere else - this server is perfectly happy serving git repositories without a .git suffix afaict...

node-git-server/src/util.ts

Line 150 in e25c481

return repo.slice(0, locationOfGit > 0 ? locationOfGit : repo.length);

This inconsistency has tripped me up a bit. I would personally be in favour of enforcing a .git suffix everywhere - possibly by redirecting to .git suffixed URL if a non-git suffixed URL is encountered.

This is inconsistent with bare/checked-out repo conventions though... which might suggest to enforce .git only if checkout is false...

I think for us we're going to enforce and stick to the suffix externally for the meantime - but it'd be good to gather opinions of other maintainers/users.

[gabrielcsapo]

I agree, we could make this an option that could be "enforceGitSuffix"? Thoughts on what it would look like for opt-in behavior?