Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(vaultwarden): update common chart to v3.5.1 #694

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

varac
Copy link

@varac varac commented Oct 31, 2024

I noticed the common chart version is pretty outdated.

Btw, I couldn't get the gen-chart-summary pre-commit hook working:


$ gc -m'chore(vaultwarden): update common chart to v3.5.1'
trim trailing whitespace.................................................Passed
fix end of files.........................................................Passed
fix utf-8 byte order marker..............................................Passed
mixed line ending........................................................Passed
check for merge conflicts................................................Passed
check for case conflicts.................................................Passed
CRLF end-lines remover...................................................Passed
Tabs remover.............................................................Passed
Artifact Hub Lint........................................................Passed
Helm Docs................................................................Passed
Generate Chart Summary...................................................Failed
- hook id: gen-chart-summary
- exit code: 2

sed: can't read /^## Chart Overview$/,$d: No such file or directory

@varac varac requested a review from gabe565 as a code owner October 31, 2024 10:44
@gabe565
Copy link
Owner

gabe565 commented Dec 2, 2024

@varac I'd like to update all of the chart dependencies, but unfortunately there are quite a few breaking changes. I have transitioned my personal infrastructure to use bjw-s's app-template chart. Here's what my Vaultwarden deployment looks like

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants